From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chad Dupuis <chad.dupuis@qlogic.com>
Subject: Re: [patch 1/2] bnx2fc: check IS_ERR() instead of NULL
Date: Wed, 5 Nov 2014 15:47:41 -0500
Message-ID: <alpine.OSX.2.00.1411051546480.2442@administrators-macbook-pro.local>
References: <20141104103717.GA19096@mwanda>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"; format=flowed
Return-path: <kernel-janitors-owner@vger.kernel.org>
In-Reply-To: <20141104103717.GA19096@mwanda>
Sender: kernel-janitors-owner@vger.kernel.org
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: QLogic-Storage-Upstream@qlogic.com, "James E.J. Bottomley" <JBottomley@parallels.com>, linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
List-Id: linux-scsi@vger.kernel.org

Looks ok.
Acked-by: Chad Dupuis <chad.dupuis@qlogic.com>

On Tue, 4 Nov 2014, Dan Carpenter wrote:

> The bnx2fc_if_create() function returns NULL on failure, it never
> returns an error pointer.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> index 79e5c94..dfed4be 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> @@ -1081,7 +1081,7 @@ static int bnx2fc_vport_create(struct fc_vport *vport, bool disabled)
> 	mutex_unlock(&bnx2fc_dev_lock);
> 	rtnl_unlock();
>
> -	if (IS_ERR(vn_port)) {
> +	if (!vn_port) {
> 		printk(KERN_ERR PFX "bnx2fc_vport_create (%s) failed\n",
> 			netdev->name);
> 		return -EIO;
>