linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chad Dupuis <chad.dupuis@qlogic.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Christoph Hellwig <hch@lst.de>,
	James Bottomley <james.bottomley@hansenpartnership.com>,
	Johannes Thumshirn <jth@kernel.org>,
	linux-scsi@vger.kernel.org, chad.dupuis@qlogic.com
Subject: Re: [RFC PATCH 0/4] libfc: Do not send ABTS when resetting exchanges
Date: Thu, 18 Aug 2016 10:38:13 -0400	[thread overview]
Message-ID: <alpine.OSX.2.00.1608181036200.529@administrators-macbook-pro.local> (raw)
In-Reply-To: <1470401703-87045-1-git-send-email-hare@suse.de>


On Fri, 5 Aug 2016, 12:54pm -0000, Hannes Reinecke wrote:

> Hi all,
> 
> here's a patchset to fixup an issue reported by QLogic: when running
> against a certain target the libfc stack would get in an infinite loop
> sending ABTS when trying to reset a connection.
> The problem is that the libfc stack is sending ABTS for any open exchanges
> when removing an rport, totally ignorant of the fact that in most cases
> we are already logged out of the said remote port.
> This patchset alters the handling slightly so that we will only ever reset
> open exchanges after we have either logged out of the port or an implicit
> logout can be assumed.
> With that we don't need to send ABTS any more during rport reset.
> 
> As usual, comments and reviews are welcome.
> 
> Hannes Reinecke (4):
>   libfc: Issue PRLI after a PRLO has been received
>   libfc: send LOGO for PLOGI failure
>   libfc: reset exchange manager during LOGO handling
>   libfc: do not send ABTS when resetting exchanges
> 
>  drivers/scsi/libfc/fc_exch.c  |  1 -
>  drivers/scsi/libfc/fc_rport.c | 26 +++++++++++++++++++++++---
>  2 files changed, 23 insertions(+), 4 deletions(-)
> 
> 

Hannes, thanks for posting this.  I've been working witih a customer of 
ours and have successfully tested this patch set.

Reviewed-by: Chad Dupuis <chad.dupuis@qlogic.com>
Tested-by: Chad Dupuis <chad.dupuis@qlogic.com>

  parent reply	other threads:[~2016-08-19  1:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-05 12:54 [RFC PATCH 0/4] libfc: Do not send ABTS when resetting exchanges Hannes Reinecke
2016-08-05 12:55 ` [PATCH 1/4] libfc: Issue PRLI after a PRLO has been received Hannes Reinecke
2016-08-05 12:55 ` [PATCH 2/4] libfc: send LOGO for PLOGI failure Hannes Reinecke
2016-08-05 12:55 ` [PATCH 3/4] libfc: reset exchange manager during LOGO handling Hannes Reinecke
2016-08-05 12:55 ` [PATCH 4/4] libfc: do not send ABTS when resetting exchanges Hannes Reinecke
2016-08-18 14:38 ` Chad Dupuis [this message]
2016-08-19  2:36 ` [RFC PATCH 0/4] libfc: Do " Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.OSX.2.00.1608181036200.529@administrators-macbook-pro.local \
    --to=chad.dupuis@qlogic.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=jth@kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).