From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chad Dupuis Subject: Re: [PATCH 10/20] libfc: Replace ->rport_logoff callback with function call Date: Wed, 19 Oct 2016 08:54:44 -0400 Message-ID: References: <1476777714-3543-1-git-send-email-hare@suse.de> <1476777714-3543-11-git-send-email-hare@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Return-path: Received: from mail-cys01nam02on0088.outbound.protection.outlook.com ([104.47.37.88]:28539 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935738AbcJSQaH (ORCPT ); Wed, 19 Oct 2016 12:30:07 -0400 In-Reply-To: <1476777714-3543-11-git-send-email-hare@suse.de> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Hannes Reinecke Cc: "Martin K. Petersen" , Johannes Thumshirn , Christoph Hellwig , Bart van Assche , James Bottomley , linux-scsi@vger.kernel.org, Hannes Reinecke On Tue, 18 Oct 2016, 8:01am -0000, Hannes Reinecke wrote: > The ->rport_logoff callback only ever had one implementation, > so we can as well call it directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/bnx2fc/bnx2fc_tgt.c | 3 +-- > drivers/scsi/fcoe/fcoe_ctlr.c | 8 ++++---- > drivers/scsi/libfc/fc_disc.c | 8 ++++---- > drivers/scsi/libfc/fc_lport.c | 10 +++++----- > drivers/scsi/libfc/fc_rport.c | 8 +++----- > include/scsi/libfc.h | 9 +-------- > 6 files changed, 18 insertions(+), 28 deletions(-) > Straightforward conversion. Reviewed-by: Chad Dupuis