From: Meelis Roos <mroos@linux.ee>
To: Tao Ma <tm@tao.ma>
Cc: Dan Williams <dan.j.williams@intel.com>,
axboe@kernel.dk, Tao Ma <boyu.mt@taobao.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org,
Ed Nadolski <edmund.nadolski@intel.com>
Subject: Re: [PATCH] block: fix blk_queue_end_tag()
Date: Wed, 21 Dec 2011 08:36:06 +0200 (EET) [thread overview]
Message-ID: <alpine.SOC.1.00.1112210835010.6858@math.ut.ee> (raw)
In-Reply-To: <4EF17DC4.5010008@tao.ma>
> > - if (unlikely(tag >= bqt->max_depth)) {
> > + if (WARN_ONCE(tag >= bqt->real_max_depth,
> > + "%s: tag %d greater than tag map size: %d\n",
> > + __func__, tag, bqt->real_max_depth)) {
> > /*
> > * This can happen after tag depth has been reduced.
> Please also change the comments here since it should never happen in the
> right workload.
What do you mean by right workload? Normal workload?
--
Meelis Roos (mroos@linux.ee)
next prev parent reply other threads:[~2011-12-21 6:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 23:33 [PATCH] block: fix blk_queue_end_tag() Dan Williams
2011-12-21 6:33 ` Tao Ma
2011-12-21 6:36 ` Meelis Roos [this message]
2011-12-21 6:48 ` Tao Ma
2011-12-21 7:30 ` Williams, Dan J
2011-12-21 8:16 ` Tao Ma
2011-12-21 8:22 ` Williams, Dan J
2011-12-21 10:05 ` Jens Axboe
2011-12-21 13:20 ` Matthew Wilcox
2011-12-21 17:37 ` Williams, Dan J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.SOC.1.00.1112210835010.6858@math.ut.ee \
--to=mroos@linux.ee \
--cc=axboe@kernel.dk \
--cc=boyu.mt@taobao.com \
--cc=dan.j.williams@intel.com \
--cc=edmund.nadolski@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox