From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hall.aurel32.net (hall.aurel32.net [195.154.119.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82A9E434982; Fri, 11 Sep 2026 20:26:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.154.119.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789158419; cv=none; b=j106Fy4gsASBMH+rviXi4hSBWfj9zmN29lYtppOwENjxPhkCpN9yKlCivBDpLUxBy9M4k+SAv2SR/hVB3DDpwEHm5Upxn6HeDjJH4yw4SUnjTVfTJ2K/ohboA1dbsmrTFonQ1dmayTKQ3VPSctX6VACjpL/lTkNnk5RO/ooWjNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789158419; c=relaxed/simple; bh=1LJDFQRP/wVIfCidTa8q9iQEePszBS6cQLu8b7MTW2k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a15bqJTnpSfm7tG0ukvDBWgBx0vZ0Q+m3udIw9LvykXncCp/4fTJkHlRGY2LIlkTEUi3/8tk4FtmGEK+gmpzD6pRUQWtzampse6lGkc5xZtnlx3O9IhSWF9rzn9ertodxOKALVtO3Q7U6BDL8ahvrFbtyOL/r/JNtdor/WTcM8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aurel32.net; spf=pass smtp.mailfrom=aurel32.net; dkim=pass (2048-bit key) header.d=aurel32.net header.i=@aurel32.net header.b=msk4qN0R; arc=none smtp.client-ip=195.154.119.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aurel32.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aurel32.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=aurel32.net header.i=@aurel32.net header.b="msk4qN0R" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=RQUxerwlfjpNkbFLTsfSSVxb37P6Hyp9X6vIryYqvRA=; b=msk4qN0RoRa3WBcE9nfXWl6Gel Zw3+5cCg8qQEfjPdKTkAqmaYB3Q+QjohsVJE9VN7I9RwG3SVLBrOc+ndi/ruOs/yw8Ee+fxo26S5Z 6hiQvRgOOBYi6ygSffwYEkISuuOvRgVD+ScKocJNM9ZvYYEgh6SFG1Cu1tvizQsLZz3fy0PFzfN29 rmkZz6Nb11UF56MLVUnFxEL9kWvvDuUR6fSHv7vA2a8z9Zi2r41dQ+K4YQXPOEZJnzL0wDvmBDfL8 fizRx+bXgLkkElrgbnFma9f7IMYWFU3Dhws51tS5ItVfYXgILskAreyMFdn8bS3e8HN6Mj0JQXuOO 10FXgY6g==; Received: from authenticated user by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x57pP-000000099ni-13MJ; Fri, 11 Sep 2026 22:26:31 +0200 Date: Fri, 11 Sep 2026 22:26:30 +0200 From: Aurelien Jarno To: Yixun Lan Cc: Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "James E.J. Bottomley" , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "Martin K. Petersen" , Anirudh Srinivasan , Jennifer Berringer , linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/3] Add UFS Host driver support for SpacemiT K3 SoC Message-ID: Mail-Followup-To: Yixun Lan , Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "James E.J. Bottomley" , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "Martin K. Petersen" , Anirudh Srinivasan , Jennifer Berringer , linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260908-08-k3-ufs-support-v4-0-22aa2bd97d3b@kernel.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260908-08-k3-ufs-support-v4-0-22aa2bd97d3b@kernel.org> User-Agent: Mutt/2.4.1 (2026-07-04) Hi Yixun, On 2026-09-08 07:42, Yixun Lan wrote: > This series try to add UFS support for SpacemiT K3 SoC, the controller > components consists of System Bus Interface Unit, UFS Host Controller > Interface, UFS Transport Protocol Layer, UFS Host Registers, Device > Management Entity (DME), Transport Layer, Network Layer, Data Link > Layer, PHY Adapter Layer, and M-PHY Interface. A more detail functional > block diagram can be found in SpacemiT website, chapter 9.7.3 [1] > > One known issue is that the device will occasionally raise BKOPS interrupt > when doing some high load test, log from dmesg shows > > [ 806.710763] ufshcd-spacemit c0e00000.ufshc: ufshcd_bkops_exception_event_handler: device raised urgent BKOPS exception for bkops status 1 > > Link: https://spacemit.com/community/document/info?nodepath=hardware/key_stone/k3/k3_docs/k3_usermanual/09_memory_storage.md&lang=en [1] > Signed-off-by: Yixun Lan > --- > Changes in v4: > - fix clock and reset settings > - drop function which retrieve value of tx_lanes > - propagate return error of ufs_spacemit_dme_set() > - check return value ufs_spacemit_check_hibern8() > - drop call to ufshcd_vops_phy_initialization() > - handle compiling warning if CONFIG_OF not enabled > add __maybe_unused to ufs_spacemit_of_match > - Link to v3: https://patch.msgid.link/20260806-08-k3-ufs-support-v3-0-037fb322acdb@kernel.org > > Changes in v3: > - collect tags > - fix dt-binding warning reported-by sashiko > - fix low freq in opp-2 table > - fix err checking in check_hibern8() > - propagate err code in link_startup_notify() > - update documents for event_notify() > - ufs clock driver is merged into v7.3-rc1, update cover letter > - Link to v2: https://patch.msgid.link/20260725-08-k3-ufs-support-v2-0-45036a2a2418@kernel.org > > Changes in v2: > - fix missing interrupts property > - move ufs node to k3-com260.dtsi > - convert freq-table-hz to operating-points-v2 > - rework reset_control, fix header and drop global variable > - drop dump_host_regs() debug interface > - converge and refactor dme_set() operations > - massive reduce of busy delay() loops > - drop vendor specific hce_enable_notify(), fallback to default > - drop unused member from struct ufs_spacemit_host > - add COMPILE_TEST support to Kconfig > - comment style fix > - Link to v1: https://patch.msgid.link/20260702-08-k3-ufs-support-v1-0-1a64a3ab128f@kernel.org > > --- > Yixun Lan (3): > scsi: ufs: spacemit: dt-bindings: Add UFS controller for K3 SoC > scsi: ufs: spacemit: k3: Add UFS Host Controller driver > riscv: dts: spacemit: k3: Add UFS support > > .../devicetree/bindings/ufs/spacemit,k3-ufshc.yaml | 56 ++ > arch/riscv/boot/dts/spacemit/k3-com260.dtsi | 4 + > arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 4 + > arch/riscv/boot/dts/spacemit/k3.dtsi | 22 + > drivers/ufs/host/Kconfig | 12 + > drivers/ufs/host/Makefile | 1 + > drivers/ufs/host/ufs-spacemit.c | 678 +++++++++++++++++++++ > drivers/ufs/host/ufs-spacemit.h | 79 +++ > 8 files changed, 856 insertions(+) > --- > base-commit: cee9395acd8043be0644b25c34bfa86623f2b935 > change-id: 20260605-08-k3-ufs-support-c8b308e415e2 Thanks for this new version. Patches 2-3 are: Tested-by: Aurelien Jarno Regards Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://aurel32.net