Re: [PATCH v4 04/54] scsi: BusLogic: Pass the host pointer directly to several functions

[Khalid Aziz <khalid@gonehiking.org>]

On Mon, Sep 28, 2026 at 10:41:38AM -0700, Bart Van Assche wrote:
> On 9/26/26 1:02 PM, Khalid Aziz wrote:
> > On Fri, Sep 25, 2026 at 11:25:42AM -0700, Bart Van Assche wrote:
> > > -static enum scsi_qc_status blogic_qcmd_lck(struct scsi_cmnd *command)
> > > +static enum scsi_qc_status blogic_qcmd_lck(struct Scsi_Host *shost, struct scsi_cmnd *command)
> > 
> > Buslogic.c defines blogic_qcmd() usind "DEF_SCSI_QCMD(blogic_qcmd)" which in turn will call
> > blogic_qcmd_lck() with just struct *scsi_cmd as a single parameter as defined in
> > include/scsi/scsi_host.h. I did not see an update to DEF_SCSI_QCMD in patches 1-3. With this
> > change, callers are not being updated and that will not work. Can you double check this?
> 
> [ ... ]
> 
> > > -static DEF_SCSI_QCMD(blogic_qcmd)
> > > +static enum scsi_qc_status blogic_qcmd(struct Scsi_Host *shost, struct scsi_cmnd *cmd)
> > > +{
> > > +	enum scsi_qc_status rc;
> > > +
> > > +	spin_lock_irq(&shost->host_lock);
> > > +	rc = blogic_qcmd_lck(shost, cmd);
> > > +	spin_unlock_irq(&shost->host_lock);
> > > +	return rc;
> > > +}
> Hi Khalid,
> 
> Please take a look at the above changes. It seems like these have been
> overlooked.

Yes, that change does modify caller. I prefer not to pull in macro definitions from
header files into the driver code. This opens up possibility for API inconsistencies if the
macro in header file is ever updated. Why not extract struct *scsi_host in blogic_qcmd_lck() from
struct *scsi_cmd instead and continue to use DEF_SCSI_QCMD()?

--
Khalid