Re: [PATCH] aic7xxx bouncing over 4G

[torvalds@transmeta.com (Linus Torvalds)]

In article <20021221174554.GA9703@redhat.com>,
Doug Ledford  <dledford@redhat.com> wrote:
>
>I actually like the individual file comments part of the cset setup.  It's 
>what my preferred use is when I'm making my own patches.  Make the cset 
>have a summary of the major changes, then let each file have it's own 
>detail change information.

I do that too, but on the whole I tend to think that if the per-file
comments are really needed (as opposed to being just nice extra and
mostly uninteresting details), there's something wrong with the CSet. 

For example, all the regular changelog tools just use the main cset
comment, and discard the file comments.  So my own rule is that the file
comments should be something fairly small and insignificant, and a good
cset should really be sufficiently explained by the cset comment. 

If the changes are so involved that you only end up condensing the
per-file comments for the global cset comment, and the per-file comments
are really interesting, then maybe that cset should have been split up
in the first place.. 

			Linus