From: Damien Le Moal <dlemoal@kernel.org>
To: "Ed Tsai (蔡宗軒)" <Ed.Tsai@mediatek.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"ming.lei@redhat.com" <ming.lei@redhat.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"mpatocka@redhat.com" <mpatocka@redhat.com>,
"mst@redhat.com" <mst@redhat.com>,
"dm-devel@lists.linux.dev" <dm-devel@lists.linux.dev>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"snitzer@kernel.org" <snitzer@kernel.org>
Subject: Re: [PATCH 4/5] block: Remove REQ_OP_ZONE_RESET_ALL emulation
Date: Thu, 4 Jul 2024 10:14:17 +0900 [thread overview]
Message-ID: <b011fe29-3602-4857-ac30-f47ce84d43d5@kernel.org> (raw)
In-Reply-To: <c2022791ae3b082d9da3694aadb4b089a991570a.camel@mediatek.com>
On 7/4/24 09:07, Ed Tsai (蔡宗軒) wrote:
>> diff --git a/block/blk-core.c b/block/blk-core.c
>> index 71b7622c523a..0c25df9758d0 100644
>> --- a/block/blk-core.c
>> +++ b/block/blk-core.c
>> @@ -834,7 +834,7 @@ void submit_bio_noacct(struct bio *bio)
>> goto not_supported;
>> break;
>> case REQ_OP_ZONE_RESET_ALL:
>> - if (!bdev_is_zoned(bio->bi_bdev) ||
>> !blk_queue_zone_resetall(q))
>> + if (!bdev_is_zoned(bio->bi_bdev))
>> goto not_supported;
>> break;
>> case REQ_OP_DRV_IN:
>
> It does the same thing as other zone operations, putting these together
> will be more cleaner?
Indeed. Will do that in v2.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-07-04 1:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 23:39 [PATCH 0/5] Remove zone reset all emulation Damien Le Moal
2024-07-03 23:39 ` [PATCH 1/5] null_blk: Introduce the zone_full parameter Damien Le Moal
2024-07-04 5:13 ` Christoph Hellwig
2024-07-03 23:39 ` [PATCH 2/5] dm: Refactor is_abnormal_io() Damien Le Moal
2024-07-04 5:13 ` Christoph Hellwig
2024-07-03 23:39 ` [PATCH 3/5] dm: handle REQ_OP_ZONE_RESET_ALL Damien Le Moal
2024-07-04 5:17 ` Christoph Hellwig
2024-07-03 23:39 ` [PATCH 4/5] block: Remove REQ_OP_ZONE_RESET_ALL emulation Damien Le Moal
2024-07-04 0:07 ` Ed Tsai (蔡宗軒)
2024-07-04 1:14 ` Damien Le Moal [this message]
2024-07-04 5:21 ` Christoph Hellwig
2024-07-03 23:39 ` [PATCH 5/5] block: Remove blk_alloc_zone_bitmap() Damien Le Moal
2024-07-04 5:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b011fe29-3602-4857-ac30-f47ce84d43d5@kernel.org \
--to=dlemoal@kernel.org \
--cc=Ed.Tsai@mediatek.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=hch@lst.de \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=mpatocka@redhat.com \
--cc=mst@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox