From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Sathya Prakash <sathya.prakash@broadcom.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org,
MPT-FusionLinux.pdl@broadcom.com
Subject: Re: [PATCH][next] scsi: mptlan: Replace one-element array with flexible-array member
Date: Tue, 6 Apr 2021 04:58:21 -0500 [thread overview]
Message-ID: <b1354342-e9c9-5fea-ab50-e996fb790a5f@embeddedor.com> (raw)
In-Reply-To: <161768454092.32082.2593948568576658600.b4-ty@oracle.com>
Hi Martin,
On 4/5/21 23:53, Martin K. Petersen wrote:
> On Wed, 24 Mar 2021 18:33:44 -0500, Gustavo A. R. Silva wrote:
>
>> There is a regular need in the kernel to provide a way to declare having
>> a dynamically sized set of trailing elements in a structure. Kernel code
>> should always use “flexible array members”[1] for these cases. The older
>> style of one-element or zero-length arrays should no longer be used[2].
>>
>> Refactor the code according to the use of a flexible-array member in
>> struct _SGE_TRANSACTION32 instead of one-element array.
>>
>> [...]
>
> Applied to 5.13/scsi-queue, thanks!
>
> [1/1] scsi: mptlan: Replace one-element array with flexible-array member
> https://git.kernel.org/mkp/scsi/c/4e2e619f3c9e
>
Thanks for this.
Could you apply this one, too:
https://lore.kernel.org/lkml/20210304203822.GA102218@embeddedor/
This was my last reply to the thread:
https://lore.kernel.org/lkml/d79bde59-16c5-e006-0e31-c33c17f0ce3d@embeddedor.com/
Thanks!
--
Gustavo
prev parent reply other threads:[~2021-04-06 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 23:33 [PATCH][next] scsi: mptlan: Replace one-element array with flexible-array member Gustavo A. R. Silva
2021-04-06 4:53 ` Martin K. Petersen
2021-04-06 9:58 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1354342-e9c9-5fea-ab50-e996fb790a5f@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=gustavoars@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox