From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Daniel Gomez <da.gomez@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Petr Pavlu <petr.pavlu@suse.com>,
Sami Tolvanen <samitolvanen@google.com>,
Aaron Tomlin <atomlin@atomlin.com>,
Lucas De Marchi <demarchi@kernel.org>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Gomez <da.gomez@samsung.com>
Subject: Re: [PATCH 0/2] scsi: target+fcoe: replace -EEXIST with -EBUSY in module_init() paths
Date: Fri, 19 Dec 2025 23:27:30 -0500 [thread overview]
Message-ID: <b1e372cacf08a758e06ce7504c6cfaf7778bc6f3.camel@HansenPartnership.com> (raw)
In-Reply-To: <20251220-dev-module-init-eexists-linux-scsi-v1-0-5379db749d54@samsung.com>
On Sat, 2025-12-20 at 04:37 +0100, Daniel Gomez wrote:
> The error code -EEXIST is reserved by the kernel module loader to
> indicate that a module with the same name is already loaded. When a
> module's init function returns -EEXIST, kmod interprets this as
> "module already loaded" and reports success instead of failure [1].
That reference doesn't sufficiently explain why this error code should
be unique to modules. EEXIST is used all over the kernel to indicate
that something being attempted has already happened or does already
exist and that seems perfectly logical .... please explain why you're
trying to push it back to being a single use case for modules alone.
Regards,
James
next prev parent reply other threads:[~2025-12-20 4:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 3:37 [PATCH 0/2] scsi: target+fcoe: replace -EEXIST with -EBUSY in module_init() paths Daniel Gomez
2025-12-20 3:37 ` [PATCH 1/2] target: replace -EEXIST with -EBUSY Daniel Gomez
2025-12-20 3:37 ` [PATCH 2/2] scsi: fcoe: " Daniel Gomez
2025-12-20 4:27 ` James Bottomley [this message]
2025-12-21 3:30 ` [PATCH 0/2] scsi: target+fcoe: replace -EEXIST with -EBUSY in module_init() paths Daniel Gomez
2025-12-21 4:02 ` James Bottomley
2025-12-21 10:00 ` Daniel Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1e372cacf08a758e06ce7504c6cfaf7778bc6f3.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=atomlin@atomlin.com \
--cc=da.gomez@kernel.org \
--cc=da.gomez@samsung.com \
--cc=demarchi@kernel.org \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox