From: Bean Huo <huobean@gmail.com>
To: liuderong@oppo.com, alim.akhtar@samsung.com, avri.altman@wdc.com,
bvanassche@acm.org, James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, peter.wang@mediatek.com,
manivannan.sadhasivam@linaro.org, ahalaney@redhat.com,
beanhuo@micron.com, quic_mnaresh@quicinc.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi:ufs:core: update compl_time_stamp_local_clock after complete a cqe
Date: Wed, 04 Dec 2024 13:50:55 +0100 [thread overview]
Message-ID: <b1e4207586a7b6bc1dbaef69627eb5c6b8e956db.camel@gmail.com> (raw)
In-Reply-To: <1733313004-350420-1-git-send-email-liuderong@oppo.com>
On Wed, 2024-12-04 at 19:50 +0800, liuderong@oppo.com wrote:
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 6a26853..bd70fe1 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -5519,6 +5519,7 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba,
> int task_tag,
>
> lrbp = &hba->lrb[task_tag];
> lrbp->compl_time_stamp = ktime_get();
> + lrbp->compl_time_stamp_local_clock = local_clock();
probably, we should change lrbp->compl_time_stamp = ktime_get(); to
lrbp->compl_time_stamp = local_clock(); also, the name of
compl_time_stamp_local_clock, is so long, should be shorter.
but the patch is ok to me:
Reviewed-by: Bean Huo <beanhuo@micron.com>
next prev parent reply other threads:[~2024-12-04 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 11:50 [PATCH] scsi:ufs:core: update compl_time_stamp_local_clock after complete a cqe liuderong
2024-12-04 12:50 ` Bean Huo [this message]
2024-12-05 5:52 ` Peter Wang (王信友)
2024-12-05 9:07 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1e4207586a7b6bc1dbaef69627eb5c6b8e956db.camel@gmail.com \
--to=huobean@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ahalaney@redhat.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liuderong@oppo.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=quic_mnaresh@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox