From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Joe Perches <joe@perches.com>,
Subhash Jadavani <subhashj@codeaurora.org>,
linux-scsi@vger.kernel.org, linux-scsi-owner@vger.kernel.org
Cc: "James E. J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Vinayak Holikatti <vinholikatti@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc()
Date: Sat, 26 Aug 2017 13:17:00 +0200 [thread overview]
Message-ID: <b218274a-da50-4f0c-2e55-cc6d708cef92@users.sourceforge.net> (raw)
In-Reply-To: <1493231242.18659.28.camel@perches.com>
>> PS: ufshcd_memory_alloc() also does some DMA coherent memory allocation
>> (via dmam_alloc_coherent() APIs) and tries to print out the message on
>> allocation failure. Although i don't know "out of memory" messages will
>> be printed out by dmam_alloc_coherent() APIs or not. If it does print it
>> out then we might want to remove our local memory allocation failure log
>> messages.
>
> Basically most everything that has a gfp_t argument does a
> dump_stack() on OOM unless __GFP_NOWARN is specified by that gfp_t.
How do you think about to continue the clarification for this aspect
of the involved programming interfaces?
Regards,
Markus
next prev parent reply other threads:[~2017-08-26 11:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 20:24 [PATCH 0/3] SCSI-UFSHCD: Fine-tuning for two function implementations SF Markus Elfring
2017-04-25 20:26 ` [PATCH 1/3] scsi: ufs: Use devm_kcalloc() in ufshcd_memory_alloc() SF Markus Elfring
2017-04-26 17:52 ` Subhash Jadavani
2017-04-25 20:28 ` [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation " SF Markus Elfring
2017-04-26 17:57 ` Subhash Jadavani
2017-04-26 18:11 ` SF Markus Elfring
2017-04-26 18:27 ` [PATCH 2/3] " Joe Perches
2017-04-26 18:50 ` Checking error messages for failed memory allocations SF Markus Elfring
2017-04-26 19:05 ` Joe Perches
2017-04-26 19:14 ` SF Markus Elfring
2017-08-26 11:17 ` SF Markus Elfring [this message]
2017-04-25 20:30 ` [PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in ufshcd_exception_event_handler() SF Markus Elfring
2017-04-26 17:59 ` Subhash Jadavani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b218274a-da50-4f0c-2e55-cc6d708cef92@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=jejb@linux.vnet.ibm.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox