Re: [PATCH v2 07/15] scsi: spi: Convert to scsi_execute_args

Bart Van Assche
2022-12-12T21:18:27Z

On 12/9/22 02:10, John Garry wrote:
> On 09/12/2022 06:13, Mike Christie wrote:
>> +    blk_opf_t opf = op | REQ_FAILFAST_DEV | REQ_FAILFAST_TRANSPORT |
>> +            REQ_FAILFAST_DRIVER;
>> +    struct scsi_exec_args exec_args = {
>> +        .req_flags = BLK_MQ_REQ_PM,
>
> I think that .sshdr could still be assigned here, like:
>         .sshdr = sshdr ? : &sshdr_tmp;

That seems like an improvement to me. Once the above suggestion has been
applied, please add:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>