From: Damien Le Moal <dlemoal@kernel.org>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] scsi: sd: Set a default optimal IO size if one is not defined
Date: Wed, 11 Jun 2025 21:29:33 +0900 [thread overview]
Message-ID: <b4688690-2b56-4053-acaa-e9e491564889@kernel.org> (raw)
In-Reply-To: <cac8143b-f321-46e3-b164-7ee6f5b1c88b@wdc.com>
On 6/11/25 19:23, Johannes Thumshirn wrote:
> On 11.06.25 09:43, Damien Le Moal wrote:
>> + if (!lim->io_opt) {
>> + lim->io_opt = ALIGN_DOWN(lim->max_sectors << SECTOR_SHIFT,
>> + sdkp->physical_block_size - 1);
>> + sd_first_printk(KERN_WARNING, sdkp,
>> + "Using default optimal transfer size of %u bytes\n",
>> + lim->io_opt);
>
> Is warning really a good logging level here? There now will be a warning
> for every ATA device in the system.
>
> I'd lower it to info.
You are absolutely right. Sending v2.
>
> Otherwise,
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2025-06-11 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 7:39 [PATCH] scsi: sd: Set a default optimal IO size if one is not defined Damien Le Moal
2025-06-11 10:23 ` Johannes Thumshirn
2025-06-11 12:29 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4688690-2b56-4053-acaa-e9e491564889@kernel.org \
--to=dlemoal@kernel.org \
--cc=Johannes.Thumshirn@wdc.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox