From: Dmitriy Bogdanov <d.bogdanov@yadro.com>
To: Mike Christie <michael.christie@oracle.com>,
Martin Petersen <martin.petersen@oracle.com>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux@yadro.com" <linux@yadro.com>,
Konstantin Shelekhin <k.shelekhin@yadro.com>,
Roman Bolshakov <r.bolshakov@yadro.com>
Subject: RE: [PATCH v3] target: core: remove from tmr_list at lun unlink
Date: Wed, 22 Sep 2021 16:43:51 +0000 [thread overview]
Message-ID: <b56124c7c8b94531bdbd7b8d2fe00633@yadro.com> (raw)
In-Reply-To: <9ca9ec9f-bc6b-9aea-3b5a-43ce5fd09b5c@oracle.com>
Hi Mike,
> Yeah, I think it's not needed. It came in with:
>
> commit 2c9fa49e100f962af988f1c0529231bf14905cda
> Author: Bart Van Assche <bvanassche@acm.org>
> Date: Tue Nov 27 15:52:03 2018 -0800
>
> scsi: target/core: Make ABORT and LUN RESET handling synchronous
> gree. It looks like it was added in:
>
> and in that patch I can't see it ever happening. We have 2 ways to submit
> an abort tmr:
>
> 1. target_submit_tmr - Calls transport_lookup_tmr_lun then
> transport_generic_handle_tmr.
>
> 2. iscsit_handle_task_mgt_cmd - Will call transport_lookup_tmr_lun
> for every tmr except the iscsi specific TASK REASSIGN. TASK REASSING
> is not passed to transport_generic_handle_tmr.
>
> I don't see any places where tmr_dev is NULL after transport_lookup_tmr_lun
> has set it and added it to the list.
>
> So I think you can just kill it.
Ok, then in the next revision of the patch I will just remove that transport_lookup_tmr_lun with WARN_ON.
BR,
Dmitry
prev parent reply other threads:[~2021-09-22 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 14:17 [PATCH v3] target: core: remove from tmr_list at lun unlink Dmitry Bogdanov
2021-09-17 16:57 ` Mike Christie
2021-09-20 16:40 ` Dmitriy Bogdanov
2021-09-22 16:00 ` Mike Christie
2021-09-22 16:43 ` Dmitriy Bogdanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b56124c7c8b94531bdbd7b8d2fe00633@yadro.com \
--to=d.bogdanov@yadro.com \
--cc=k.shelekhin@yadro.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=r.bolshakov@yadro.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox