From: Mike Christie <michael.christie@oracle.com>
To: Konstantin Shelekhin <k.shelekhin@yadro.com>,
Dmitry Bogdanov <d.bogdanov@yadro.com>
Cc: Martin Petersen <martin.petersen@oracle.com>,
target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux@yadro.com, Roman Bolshakov <r.bolshakov@yadro.com>
Subject: Re: [PATCH] scsi: target: core: Add a way to hide a port group
Date: Fri, 9 Sep 2022 12:24:51 -0500 [thread overview]
Message-ID: <b5dc6104-04e1-c3f0-b22d-ff9043cd9f36@oracle.com> (raw)
In-Reply-To: <YxskUBeZeMPi5By2@yadro.com>
On 9/9/22 6:32 AM, Konstantin Shelekhin wrote:
>> The patch solves the presence of non-deletable empty default_tg_pt_gp
>> in RTPG.
>> May be, a global attribute like target/core/alua/hide_emtpy_tpg would
>> fit better than an attribute per each port group?
>>
>> I would always hide the empty default_lu_gp (not configurable) but I am
>> afraid that it will be considered as not backward compatible change. 🙁
> A module parameter perhaps? Or a CONFIG definition.
For the ceph iscsi project we wanted this same behavior for a while and
we had to use distro kernels. There are probably others that need the same
thing so a kernel config option wouldn't work for them.
Module param or a global attr in target/core/alua like Dimitry mentioned
seem fine. If the new variable is set are you guys thinking that
core_tpg_add_lun would just not call target_attach_tg_pt_gp? So the variable
would be "make_default_tg_pt_gp"?
next prev parent reply other threads:[~2022-09-09 17:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 7:49 [PATCH] scsi: target: core: Add a way to hide a port group Dmitry Bogdanov
2022-09-07 20:01 ` Mike Christie
2022-09-09 11:22 ` Dmitry Bogdanov
2022-09-09 11:32 ` Konstantin Shelekhin
2022-09-09 17:24 ` Mike Christie [this message]
2022-09-12 12:30 ` Dmitry Bogdanov
2022-09-09 17:17 ` Mike Christie
-- strict thread matches above, loose matches on Subject: below --
2020-04-04 10:48 Dmitry Bogdanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5dc6104-04e1-c3f0-b22d-ff9043cd9f36@oracle.com \
--to=michael.christie@oracle.com \
--cc=d.bogdanov@yadro.com \
--cc=k.shelekhin@yadro.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=r.bolshakov@yadro.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox