From: James Smart <jsmart2021@gmail.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: linux-scsi@vger.kernel.org,
Dick Kennedy <dick.kennedy@broadcom.com>,
James Smart <james.smart@broadcom.com>
Subject: Re: [PATCH v2 06/13] lpfc: Add 64G link speed support
Date: Wed, 7 Feb 2018 07:38:39 -0800 [thread overview]
Message-ID: <b626516f-3569-59b7-4472-7668f96d0c46@gmail.com> (raw)
In-Reply-To: <20180207095846.gkh3oc3k5pnr6mlt@linux-x5ow.site>
On 2/7/2018 1:58 AM, Johannes Thumshirn wrote:
> On Tue, Feb 06, 2018 at 06:28:44PM -0800, James Smart wrote:
>> lpfc_printf_log(phba, KERN_ERR, LOG_INIT,
>> - "0469 lpfc_link_speed attribute cannot be set to %d, "
>> - "allowed values are ["LPFC_LINK_SPEED_STRING"]\n", val);
>> + "0469 lpfc_link_speed attribute cannot be set to %d, "
>> + "allowed values are ["LPFC_LINK_SPEED_STRING"]\n", val);
>
> lpfc_printf_log(phba, KERN_ERR, LOG_INIT,
> "0469 lpfc_link_speed attribute cannot be set to %d, "
> "allowed values are [%s]\n",
> val, LPFC_LINK_SPEED_STRING);
>
> And possible have the whole quoted string on one line for easier grepping.
> checkplatch.pl should've told you that.
>
Checkpatch didn't say anything interesting. We consistently have line
spanning as the lines are fairly verbose. Not an easy way to avoid that.
Regardless, no big deal.
-- james
next prev parent reply other threads:[~2018-02-07 15:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 2:28 [PATCH v2 00/13] lpfc new hardware patches for 12.0.0.0 James Smart
2018-02-07 2:28 ` [PATCH v2 01/13] lpfc: Rework lpfc to allow different sli4 cq and eq handlers James Smart
2018-02-07 9:01 ` Johannes Thumshirn
2018-02-07 2:28 ` [PATCH v2 02/13] lpfc: Rework sli4 doorbell infrastructure James Smart
2018-02-07 9:13 ` Johannes Thumshirn
2018-02-07 2:28 ` [PATCH v2 03/13] lpfc: Add SLI-4 if_type=6 support to the code base James Smart
2018-02-07 9:17 ` Johannes Thumshirn
2018-02-07 2:28 ` [PATCH v2 04/13] lpfc: Add push-to-adapter support to sli4 James Smart
2018-02-07 9:51 ` Johannes Thumshirn
2018-02-07 10:27 ` Johannes Thumshirn
2018-02-07 15:42 ` James Smart
2018-02-13 5:59 ` Michael Ellerman
2018-02-13 17:37 ` James Smart
2018-02-07 2:28 ` [PATCH v2 05/13] lpfc: Add PCI Ids for if_type=6 hardware James Smart
2018-02-07 9:52 ` Johannes Thumshirn
2018-02-07 2:28 ` [PATCH v2 06/13] lpfc: Add 64G link speed support James Smart
2018-02-07 9:58 ` Johannes Thumshirn
2018-02-07 15:38 ` James Smart [this message]
2018-02-07 15:40 ` Johannes Thumshirn
2018-02-07 2:28 ` [PATCH v2 07/13] lpfc: Add if_type=6 support for cycling valid bits James Smart
2018-02-07 10:01 ` Johannes Thumshirn
2018-02-07 2:28 ` [PATCH v2 08/13] lpfc: Enable fw download on if_type=6 devices James Smart
2018-02-07 10:03 ` Johannes Thumshirn
2018-02-07 2:28 ` [PATCH v2 09/13] lpfc: Add embedded data pointers for enhanced performance James Smart
2018-02-07 10:17 ` Johannes Thumshirn
2018-02-07 2:28 ` [PATCH v2 10/13] lpfc: Fix nvme embedded io length on new hardware James Smart
2018-02-07 10:32 ` Johannes Thumshirn
2018-02-07 2:28 ` [PATCH v2 11/13] lpfc: Work around NVME cmd iu SGL type James Smart
2018-02-07 10:39 ` Johannes Thumshirn
2018-02-07 2:28 ` [PATCH v2 12/13] lpfc: update driver version to 12.0.0.0 James Smart
2018-02-07 10:39 ` Johannes Thumshirn
2018-02-07 2:28 ` [PATCH v2 13/13] lpfc: Update 12.0.0.0 modified files for 2018 Copyright James Smart
2018-02-07 10:50 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b626516f-3569-59b7-4472-7668f96d0c46@gmail.com \
--to=jsmart2021@gmail.com \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).