From: Mike Christie <michael.christie@oracle.com>
To: kensanya@163.com, "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Hannes Reinecke <hare@suse.de>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
TanZheng <tanzheng@kylinos.cn>
Subject: Re: [PATCH] scsi: target: iblock: Fix wrong PR ops NULL check for PREEMPT/RELEASE
Date: Fri, 24 Jul 2026 13:33:19 -0500 [thread overview]
Message-ID: <b66a2efb-e103-4428-a081-068e2859d3fc@oracle.com> (raw)
In-Reply-To: <20260724075850.280699-1-kensanya@163.com>
On 7/24/26 2:58 AM, kensanya@163.com wrote:
> From: TanZheng <tanzheng@kylinos.cn>
>
> In the iblock_execute_pr_out function, PRO_PREEMPT, PRO_PREEMPT_AND_ABORT
> and PRO_RELEASE all perform callback capability checks through
> ops->pr_clear. The error check allows unimplemented hooks to pass through
> the gate, resulting dereferencing a NULL function pointer.
>
> Check whether the hooks that need to be called are supported.
>
> Fixes: 394f81184882 ("scsi: target: Add block PR support to iblock")
> Signed-off-by: TanZheng <tanzheng@kylinos.cn>
Reviewed-by: Mike Christie <michael.christie@oracle.com>
prev parent reply other threads:[~2026-07-24 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 7:58 [PATCH] scsi: target: iblock: Fix wrong PR ops NULL check for PREEMPT/RELEASE kensanya
2026-07-24 8:12 ` sashiko-bot
2026-07-24 18:33 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b66a2efb-e103-4428-a081-068e2859d3fc@oracle.com \
--to=michael.christie@oracle.com \
--cc=hare@suse.de \
--cc=kensanya@163.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tanzheng@kylinos.cn \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox