From: Bart Van Assche <bvanassche@acm.org>
To: Bean Huo <beanhuo@iokpp.de>,
avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, can.guo@oss.qualcomm.com,
ulf.hansson@linaro.org, beanhuo@micron.com,
jens.wiklander@linaro.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] scsi: ufs: core: fix incorrect buffer duplication in ufshcd_read_string_desc()
Date: Wed, 1 Oct 2025 12:43:18 -0700 [thread overview]
Message-ID: <b6a82f74-f64a-4706-8663-c6a72332fbb2@acm.org> (raw)
In-Reply-To: <20251001060805.26462-3-beanhuo@iokpp.de>
On 9/30/25 11:08 PM, Bean Huo wrote:
> The function ufshcd_read_string_desc() was duplicating memory starting
> from the beginning of struct uc_string_id, which included the length
> and type fields. As a result, the allocated buffer contained unwanted
> metadata in addition to the string itself.
>
> The correct behavior is to duplicate only the Unicode character array in
> the structure. Update the code so that only the actual string content is
> copied into the new buffer.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2025-10-01 19:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 6:08 [PATCH v2 0/3] Add OP-TEE based RPMB driver for UFS devices Bean Huo
2025-10-01 6:08 ` [PATCH v2 1/3] rpmb: move rpmb_frame struct and constants to common header Bean Huo
2025-10-01 9:48 ` Avri Altman
2025-10-01 19:43 ` Bart Van Assche
2025-10-06 10:07 ` Jens Wiklander
2025-10-06 10:21 ` Ulf Hansson
2025-10-06 10:54 ` Bean Huo
2025-10-01 6:08 ` [PATCH v2 2/3] scsi: ufs: core: fix incorrect buffer duplication in ufshcd_read_string_desc() Bean Huo
2025-10-01 10:03 ` Avri Altman
2025-10-02 4:31 ` Bean Huo
2025-10-01 19:43 ` Bart Van Assche [this message]
2025-10-01 6:08 ` [PATCH v2 3/3] scsi: ufs: core: Add OP-TEE based RPMB driver for UFS devices Bean Huo
2025-10-01 7:50 ` Jens Wiklander
2025-10-02 13:37 ` Bean Huo
2025-10-08 15:07 ` Bean Huo
2025-10-13 8:21 ` Jens Wiklander
2025-10-13 12:04 ` Bean Huo
2025-10-13 12:22 ` Jens Wiklander
2025-10-13 15:42 ` Bean Huo
2025-10-13 15:53 ` Jens Wiklander
2025-10-23 11:32 ` Bean Huo
2025-10-01 10:06 ` Avri Altman
2025-10-02 13:19 ` Bean Huo
2025-10-08 11:47 ` Bean Huo
2025-10-08 12:16 ` Avri Altman
2025-10-01 19:51 ` Bart Van Assche
2025-10-02 13:38 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6a82f74-f64a-4706-8663-c6a72332fbb2@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@iokpp.de \
--cc=beanhuo@micron.com \
--cc=can.guo@oss.qualcomm.com \
--cc=jejb@linux.ibm.com \
--cc=jens.wiklander@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).