Re: [PATCH V3 4/5] arm64: dts: qcom: sm8650: Enable MCQ support for UFS controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 29/08/2025 18:18, Manivannan Sadhasivam wrote:
> On Thu, Aug 21, 2025 at 01:49:36PM GMT, Krzysztof Kozlowski wrote:
>> On 21/08/2025 13:24, Ram Kumar Dwivedi wrote:
>>> Enable Multi-Circular Queue (MCQ) support for the UFS host controller
>>> on the Qualcomm SM8650 platform by updating the device tree node. This
>>> includes adding new register region for MCQ and specifying the MSI parent
>>> required for MCQ operation.
>>>
>>> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/sm8650.dtsi | 7 ++++++-
>>
>> I don't understand why you combine DTS patch into UFS patchset. This
>> creates impression of dependent work, which would be a trouble for merging.
>>
> 
> What trouble? Even if the DTS depends on the driver/bindings change, can't it
> still go through a different tree for the same cycle? It happened previously as

It all depends on sort of dependency.

> well, unless the rule changed now.

No, the point is that there is absolutely nothing relevant between the
DTS and drivers here. Combining unrelated patches, completely different
ones, targeting different subsystems into one patchset was always a
mistake. This makes only life of maintainers more difficult, for no gain.


Best regards,
Krzysztof