re: ufs: add ioctl interface for query request

["Gilad Broner" <gbroner@codeaurora.org>]

> copy_to/from_user() returns the number of bytes not copied and not an
> error code.  Printing these error messages in the ioctl means the user
> can trigger a DoS by filling up /var/log/messages.  They make the code
> uglier.  We should stop here if the copy fails and goto out_release_mem
> otherwise we might end up returning success by mistake.

Thanks for the comment, I will update the code.
I wanted to clarify about the possibility of a DoS attack:
- Isn't var/log/messages cyclic or size limited in some way?
- What determines that dev_err() prints go to /var/log/messages?
  would it still be the case if dev_dbg() was used instead?

Thanks,
Gilad.



-- 
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project