From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Smart Subject: Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test Date: Wed, 23 Aug 2017 09:20:15 -0700 Message-ID: References: <20170822205353.GA17794@embeddedgus> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170822205353.GA17794@embeddedgus> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: "Gustavo A. R. Silva" , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On 8/22/2017 1:53 PM, Gustavo A. R. Silva wrote: > Remove variable assignments. The value stored in local variable _rc_ is > overwritten at line 2448:rc = lpfc_sli4_bsg_set_link_diag_state(phba, 0); > before it can be used. > > Addresses-Coverity-ID: 1226935 > Signed-off-by: Gustavo A. R. Silva > --- > This issue was detected by Coverity and it was tested by compilation only. > Notice that this code has been there since 2011. > > drivers/scsi/lpfc/lpfc_bsg.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > looks good. Thanks Signed-off-by: James Smart -- james