RE: [PATCH v1 2/2] scsi: ufs: Cleanup device vendor and quirk definition

Stanley Chu
2020-06-12T01:27:34Z

Hi Alim,

On Thu, 2020-06-11 at 21:04 +0530, Alim Akhtar wrote:
> Hi Stanley
>
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index
> > dea4fddf9332..7c93cb446f51 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++ b/drivers/scsi/ufs/ufshcd.c
> > @@ -219,10 +219,8 @@ static struct ufs_dev_fix ufs_fixups[] = {
> > UFS_FIX(UFS_VENDOR_MICRON, UFS_ANY_MODEL,
> > UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
> > UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
> > - UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
> > - UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
> > - UFS_DEVICE_QUIRK_RECOVERY_FROM_DL_NAC_ERRORS),
> > - UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
> > + UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM |
> > + UFS_DEVICE_QUIRK_RECOVERY_FROM_DL_NAC_ERRORS |
> > UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE),
> > UFS_FIX(UFS_VENDOR_TOSHIBA, UFS_ANY_MODEL,
> > UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
> > --
> While at this, may be arrange the table in alphabetical order.

Sure, fixed in v2.

Thanks for the review.
Stanley Chu