From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24D291ADC83 for ; Mon, 8 Sep 2025 18:31:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=44.202.169.35 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757356277; cv=none; b=KfvoKzT2kyPFkjwFX9zf14tZdJZJ4JR/0AIj9AcJu9PoTHe/VrPwz3JIn6cc93xVO5HNZ89WWr5/4NPUfkiIeMEwR24rcFrRmN6odemnBxkjD4sNmAD5oyxIhuh5F34lVRqLMrxv/OCO9jvZJ7B8a/8nV3jRiL9BuIRszGJCP5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757356277; c=relaxed/simple; bh=wX9+IS0vJCWpzgflmJfrK2PcQPvegoFGe02wuEOQJSg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Jwivpc9sBMofN8I06dOBqG6Hhabn5Q7CHZ7hNBBMIsvMj0qq7UQwSX6YMvDaYofR4T1LquI/XsnIl5S35RilkSGncRDcHQ0ysgvXqlH/fVYXClv8eCkjYWerAkqITFA+CFZwoT/CrWIfVrj3A/7WLirkMOxAZhA3ZkNJ/tDIBKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com; spf=pass smtp.mailfrom=embeddedor.com; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b=xtdIxK5w; arc=none smtp.client-ip=44.202.169.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="xtdIxK5w" Received: from eig-obgw-5006b.ext.cloudfilter.net ([10.0.29.217]) by cmsmtp with ESMTPS id veI5uO19xKXDJvgdwulZG4; Mon, 08 Sep 2025 18:31:08 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id vgdvuPxIkcL7DvgdvuicZn; Mon, 08 Sep 2025 18:31:07 +0000 X-Authority-Analysis: v=2.4 cv=Xqb6OUF9 c=1 sm=1 tr=0 ts=68bf20eb a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=3MMl4rzW2iVmjiC4vQKzZA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=7T7KSl7uo7wA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=DahiFt0k3YZEWpF1MlMA:9 a=QEXdDO2ut3YA:10 a=xYX6OU9JNrHFPr8prv8u:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SYa6hIJu3DY3TfnACEOnPdfbIxpdF/KfJFBTzkY9dx8=; b=xtdIxK5wsVqVSyqv6rAfYyyZ5v tHcMo9tds+hMG5WI2blz/uL2oX1M6sb0tfnn0TOUeZmlb6KUAuc5FsNE3L8Mk+0beC87Dr5Y00amO JIqruWo5s3dHw4Yep5g6K7FE3biTCW65VQIOpRcvFt21yqP9Wom+DrsOExDjziN+gItNVF2gX5WhU laH0LXoigohmw8h/T9VLpIEMz23GBzp36rMzTbDoGch+fQM7DJzhmMLAlX0tiDDigQGDwXi52ghWF 79bNQOYkmvYFM6uipNgUhT+pDdIMeuGyAeLgfRxapBjiYgiCkYE3hsrjXCAdByOf7ajcmAMIGMffh jxKueYDg==; Received: from 250-136.dsl.iskon.hr ([89.164.250.136]:49258 helo=[172.30.86.44]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.1) (envelope-from ) id 1uvgdu-00000001s8F-1vKZ; Mon, 08 Sep 2025 13:31:06 -0500 Message-ID: Date: Mon, 8 Sep 2025 20:30:58 +0200 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2][next] scsi: pm80xx: Avoid -Wflex-array-member-not-at-end warnings To: John Garry , "Gustavo A. R. Silva" , Jack Wang , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <47624b76-3b19-4805-b48a-040e943c7f2a@oracle.com> Content-Language: en-US From: "Gustavo A. R. Silva" In-Reply-To: <47624b76-3b19-4805-b48a-040e943c7f2a@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 89.164.250.136 X-Source-L: No X-Exim-ID: 1uvgdu-00000001s8F-1vKZ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 250-136.dsl.iskon.hr ([172.30.86.44]) [89.164.250.136]:49258 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 3 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfAny6namX5m4jhz60j+y8yJAEdPW0FYc95NOtQyBE2vhJoEavRgGhPeRa/IO8vgPLm27cU7YUIIr8BvZQ2b1g86EZIl0a/dEuU5jeMLuQdzXGdfbffvS /P2gmV5NZaS1/BTExImpzeYSchNKQ7j7WyAafT7+zfMKrbDCy6HUWhVSM5p2jAKDq4o1zRgqQEbtfB8E71o9vms+6RLOjFProlBwS1Z/J/m10tBsVQOqKPCZ On 9/5/25 09:05, John Garry wrote: > On 04/09/2025 15:54, Gustavo A. R. Silva wrote: >> Remove unused field residual_count in a couple of structures, >> and with this, fix the following -Wflex-array-member-not-at-end >> warnings: >> >> drivers/scsi/pm8001/pm8001_hwi.h:342:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member- >> not-at-end] >> drivers/scsi/pm8001/pm80xx_hwi.h:561:32: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member- >> not-at-end] >> >> Signed-off-by: Gustavo A. R. Silva > > Personally I think that it would be better to comment-out the residual_count member, so that future developers can know about this field and why it is not there. I agree. I'll send v3. > > Anyway, > > Reviewed-by: John Garry Thanks! -Gustavo