From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>
Subject: Re: [PATCH 2/2] block: remove blk_rq_bio_prep
Date: Mon, 3 Feb 2025 16:50:14 +0000 [thread overview]
Message-ID: <bd17602e-cb39-461c-8e89-6637c54c3a38@nvidia.com> (raw)
In-Reply-To: <20250103073417.459715-3-hch@lst.de>
On 1/2/25 23:33, Christoph Hellwig wrote:
> There is not real point in a helper just to assign three values to four
> fields, especially when the surrounding code is working on the
> neighbor fields directly.
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2025-02-03 16:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 7:33 simplify passthrough bio handling Christoph Hellwig
2025-01-03 7:33 ` [PATCH 1/2] block: remove bio_add_pc_page Christoph Hellwig
2025-01-04 22:11 ` Sagi Grimberg
2025-02-03 16:49 ` Chaitanya Kulkarni
2025-01-03 7:33 ` [PATCH 2/2] block: remove blk_rq_bio_prep Christoph Hellwig
2025-01-04 22:11 ` Sagi Grimberg
2025-02-03 16:50 ` Chaitanya Kulkarni [this message]
2025-01-04 22:27 ` simplify passthrough bio handling Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd17602e-cb39-461c-8e89-6637c54c3a38@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox