From: Paolo Bonzini <pbonzini@redhat.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
KVM General <kvm@vger.kernel.org>,
jejb@linux.ibm.com,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Linux SCSI List <linux-scsi@vger.kernel.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH 1/2] scsi_host: add support for request batching
Date: Mon, 3 Jun 2019 10:16:21 +0200 [thread overview]
Message-ID: <bd7fa062-6c71-13a2-5bbf-0dea859ae75f@redhat.com> (raw)
In-Reply-To: <CACVXFVP-B7uKUGn75rZdu0e4QxUOsSqv8FL0vY2ubmuucvxqjQ@mail.gmail.com>
On 31/05/19 05:27, Ming Lei wrote:
> It should be fine to implement scsi_commit_rqs() as:
>
> if (shost->hostt->commit_rqs)
> shost->hostt->commit_rqs(shost, hctx->queue_num);
>
> then scsi_mq_ops_no_commit can be saved.
>
> Because .commit_rqs() is only called when BLK_STS_*_RESOURCE is
> returned from scsi_queue_rq(), at that time shost->hostt->commit_rqs should
> have been hit from cache given .queuecommand is called via
> host->hostt->queuecommand.
This is not about d-cache, it's about preserving the heuristics that
blk-mq applies depending on whether commit_rqs is there or not.
Paolo
next prev parent reply other threads:[~2019-06-03 8:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 11:28 [PATCH 0/2] scsi: add support for request batching Paolo Bonzini
2019-05-30 11:28 ` [PATCH 1/2] scsi_host: " Paolo Bonzini
2019-05-30 15:36 ` Bart Van Assche
2019-05-30 15:54 ` Paolo Bonzini
2019-05-30 17:54 ` Bart Van Assche
2019-05-31 9:12 ` Paolo Bonzini
2019-05-31 3:27 ` Ming Lei
2019-06-03 8:16 ` Paolo Bonzini [this message]
2019-07-05 1:00 ` Ming Lei
2019-06-04 22:40 ` Bart Van Assche
2019-06-19 8:11 ` Hannes Reinecke
2019-06-19 10:31 ` Paolo Bonzini
2019-07-04 13:19 ` Paolo Bonzini
2019-07-05 7:12 ` Hannes Reinecke
2019-07-05 7:44 ` Stefan Hajnoczi
2019-07-05 7:51 ` Hannes Reinecke
2019-05-30 11:28 ` [PATCH 2/2] virtio_scsi: implement " Paolo Bonzini
2019-05-30 17:28 ` Bart Van Assche
2019-05-31 9:03 ` Paolo Bonzini
2019-07-05 7:52 ` Hannes Reinecke
2019-07-08 9:47 ` Ming Lei
2019-06-10 12:36 ` [PATCH 0/2] scsi: add support for " Stefan Hajnoczi
2019-06-26 13:51 ` Paolo Bonzini
2019-06-26 14:14 ` Douglas Gilbert
2019-06-26 14:50 ` Paolo Bonzini
2019-06-27 3:37 ` Martin K. Petersen
2019-06-27 8:17 ` Paolo Bonzini
2019-07-05 7:13 ` Hannes Reinecke
2019-07-05 11:58 ` Paolo Bonzini
2019-07-12 1:37 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd7fa062-6c71-13a2-5bbf-0dea859ae75f@redhat.com \
--to=pbonzini@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stefanha@redhat.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).