From: Bart Van Assche <bvanassche@acm.org>
To: "Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
quic_cang@quicinc.com, quic_nitirawa@quicinc.com,
avri.altman@wdc.com, beanhuo@micron.com, adrian.hunter@intel.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] scsi: ufs: qcom: Update the UIC Command Timeout
Date: Wed, 22 May 2024 14:01:49 -0700 [thread overview]
Message-ID: <bdd52dc0-85dd-4000-b5dd-c2c22f5b8ba1@acm.org> (raw)
In-Reply-To: <f9595b82-66f9-dce2-7fba-c42b1eacf962@quicinc.com>
On 5/22/24 13:56, Bao D. Nguyen wrote:
> On 5/22/2024 11:18 AM, Bart Van Assche wrote:
>> Since the described issue is only encountered during development, why to
>> modify the UIC command timeout unconditionally?
>
> The vendors can enjoy the default 500ms UIC timeout if they prefer.
> As long as they don't write to hba->uic_cmd_timeout in the vendor's initialization routine, the default value of 500ms will be used.
Since this issue is not vendor specific, I think it would be better to
modify the UFSHCI core driver only. Has it been considered to introduce a
kernel module parameter for setting the UIC command timeout instead of the
approach of this patch? As you probably know there are multiple mechanisms
for specifying kernel module parameters, e.g. the bootargs parameter in the
device tree.
Thanks,
Bart.
next prev parent reply other threads:[~2024-05-22 21:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 7:01 [PATCH v1 0/2] Allow vendor drivers to update UIC command timeout Bao D. Nguyen
2024-05-22 7:01 ` [PATCH v1 1/2] scsi: ufs: core: Support Updating UIC Command Timeout Bao D. Nguyen
2024-05-22 18:16 ` Bart Van Assche
2024-05-22 20:51 ` Bao D. Nguyen
2024-05-23 4:38 ` Manivannan Sadhasivam
2024-05-23 5:40 ` Bao D. Nguyen
2024-05-22 7:01 ` [PATCH v1 2/2] scsi: ufs: qcom: Update the " Bao D. Nguyen
2024-05-22 18:18 ` Bart Van Assche
2024-05-22 20:56 ` Bao D. Nguyen
2024-05-22 21:01 ` Bart Van Assche [this message]
2024-05-23 3:18 ` Avri Altman
2024-05-23 5:42 ` Bao D. Nguyen
2024-05-23 5:34 ` Bao D. Nguyen
2024-05-23 8:17 ` [PATCH v1 0/2] Allow vendor drivers to update UIC command timeout Christoph Hellwig
2024-05-23 14:28 ` Bao D. Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdd52dc0-85dd-4000-b5dd-c2c22f5b8ba1@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=jejb@linux.ibm.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox