From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"evgreen@chromium.org" <evgreen@chromium.org>,
"vinholikatti@gmail.com" <vinholikatti@gmail.com>,
Stanislav Nijnikov <Stanislav.Nijnikov@wdc.com>
Cc: "gwendal@chromium.org" <gwendal@chromium.org>
Subject: Re: [PATCH 3/7] scsi: ufs: Make sysfs attributes writable
Date: Mon, 4 Jun 2018 08:33:46 +0000 [thread overview]
Message-ID: <bde08554b8939de962a88068bb132ab320f8f7a5.camel@wdc.com> (raw)
In-Reply-To: <20180529181740.195362-4-evgreen@chromium.org>
On Tue, 2018-05-29 at 11:17 -0700, Evan Green wrote:
> +static ssize_t _name##_store(struct device *dev, \
> + struct device_attribute *attr, const char *buf, \
> + size_t count) \
> +{ \
> + struct ufs_hba *hba = dev_get_drvdata(dev); \
> + unsigned long value; \
> + if (kstrtoul(buf, 0, &value)) \
> + return -EINVAL; \
> + if (ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_WRITE_ATTR, \
> + QUERY_ATTR_IDN##_uname, 0, 0, (u32 *)&value)) \
> + return -EINVAL; \
> + return count; \
> +} \
Casting an "unsigned long" pointer into an u32 pointer looks evil to me.
Please don't do this.
Thanks,
Bart.
next prev parent reply other threads:[~2018-06-04 8:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 18:17 [PATCH 0/7] Enable UFS provisioning via Linux Evan Green
2018-05-29 18:17 ` [PATCH 1/7] scsi: ufs: Add Configuration Descriptor to sysfs Evan Green
2018-06-04 8:31 ` Bart Van Assche
2018-06-04 15:39 ` Evan Green
2018-05-29 18:17 ` [PATCH 2/7] scsi: ufs: Add config descriptor documentation Evan Green
2018-06-04 8:34 ` Bart Van Assche
2018-06-04 15:39 ` Evan Green
2018-05-29 18:17 ` [PATCH 3/7] scsi: ufs: Make sysfs attributes writable Evan Green
2018-06-04 8:33 ` Bart Van Assche [this message]
2018-06-04 15:39 ` Evan Green
2018-05-29 18:17 ` [PATCH 4/7] scsi: ufs: sysfs: Document attribute writability Evan Green
2018-06-04 8:35 ` Bart Van Assche
2018-06-04 15:39 ` Evan Green
2018-05-29 18:17 ` [PATCH 5/7] scsi: ufs: Refactor descriptor read for write Evan Green
2018-05-30 17:21 ` Evan Green
2018-06-04 8:40 ` Bart Van Assche
2018-06-04 15:40 ` Evan Green
2018-05-29 18:17 ` [PATCH 6/7] scsi: ufs: Enable writing config descriptor Evan Green
2018-06-04 8:46 ` Bart Van Assche
2018-05-29 18:17 ` [PATCH 7/7] scsi: ufs: Update config descriptor documentation Evan Green
2018-05-31 10:04 ` [PATCH 0/7] Enable UFS provisioning via Linux Stanislav Nijnikov
2018-06-01 14:44 ` Evan Green
2018-06-03 10:21 ` Stanislav Nijnikov
2018-06-04 14:59 ` Evan Green
2018-06-08 12:30 ` Adrian Hunter
2018-06-10 9:31 ` Stanislav Nijnikov
2018-06-12 19:42 ` Evan Green
2018-06-12 20:11 ` Bart Van Assche
2018-06-13 10:12 ` Stanislav Nijnikov
2018-06-15 21:19 ` Evan Green
2018-06-04 11:11 ` Kyuho Choi
2018-06-04 15:03 ` Evan Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bde08554b8939de962a88068bb132ab320f8f7a5.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=Stanislav.Nijnikov@wdc.com \
--cc=evgreen@chromium.org \
--cc=gwendal@chromium.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox