Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Xose Vazquez Perez <xose.vazquez@gmail.com>
To: Hannes Reinecke <hare@suse.de>,
	Alan Stern <stern@rowland.harvard.edu>,
	Bart Van Assche <bart.vanassche@wdc.com>,
	Martin Wilck <mwilck@suse.com>,
	Martin Petersen <martin.petersen@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	linux-scsi <linux-scsi@vger.kernel.org>
Subject: scsi_devinfo: devices and pattern matching
Date: Sat, 16 Dec 2017 14:31:34 +0100	[thread overview]
Message-ID: <bebefebe-e1b8-5f15-a59d-ed5099ebcf4e@gmail.com> (raw)

Hi,

After last pattern matching changes, maybe some entries should be revised:


Empty strings(current meaning?):
	{"", "Scanner", "1.80", BLIST_NOLUN},	/* responds to all lun */
	{"Promise", "", NULL, BLIST_SPARSELUN},
	{"HP", "C1790A", "", BLIST_NOLUN},		/* scanjet iip */
	{"HP", "C2500A", "", BLIST_NOLUN},		/* scanjet iicx */


Overlapping(?) strings(remove one???):
	{"DELL", "PV660F", NULL, BLIST_SPARSELUN},
	{"DELL", "PV660F   PSEUDO", NULL, BLIST_SPARSELUN},

	{"NRC", "MBR-7", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
	{"NRC", "MBR-7.4", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
	
	{"Promise", "", NULL, BLIST_SPARSELUN},
	{"Promise", "VTrak E610f", NULL, BLIST_SPARSELUN | BLIST_NO_RSOC},


Odd "revision level" string(is it right? EOT?):
        {"SEAGATE", "ST157N", "\004|j", BLIST_NOLUN},


Duplicate strings(They should be merged):
	{"TEXEL", "CD-ROM", "1.06", BLIST_BORKEN},
	{"TEXEL", "CD-ROM", "1.06", BLIST_NOLUN},


Keep in mind, for future patches, that there are regex metacharacters(!!):
        {"IOMEGA", "Io20S         *F", NULL, BLIST_KEY},
        {"INSITE", "Floptical   F*8I", NULL, BLIST_KEY},
        {"DELL", "PSEUDO DEVICE .", NULL, BLIST_SPARSELUN},     /* Dell PV 530F */


For homogeneity reasons, should "*" revision level be replaced by NULL?


And the current pattern matching algorithm should be described clearer, right
now it's a bit confused.


Thank you.

             reply	other threads:[~2017-12-16 13:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-16 13:31 Xose Vazquez Perez [this message]
2017-12-18  8:36 ` scsi_devinfo: devices and pattern matching Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bebefebe-e1b8-5f15-a59d-ed5099ebcf4e@gmail.com \
    --to=xose.vazquez@gmail.com \
    --cc=bart.vanassche@wdc.com \
    --cc=hare@suse.de \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mwilck@suse.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox