Re: [PATCH 07/10] scsi: libsas: Delete sas_ssp_task.task_prio

John Garry
2023-08-15T07:46:17Z

On 15/08/2023 03:17, Damien Le Moal wrote:
>> --- a/drivers/scsi/isci/request.c
>> +++ b/drivers/scsi/isci/request.c
>> @@ -180,7 +180,6 @@ static void sci_io_request_build_ssp_command_iu(struct isci_request *ireq)
>> cmd_iu->_r_a = 0;
>> cmd_iu->_r_b = 0;
>> cmd_iu->en_fburst = 0; /* unsupported */
>> - cmd_iu->task_prio = task->ssp_task.task_prio;
> Shouldn't this be replaced with:
>
> cmd_iu->task_prio = 0;
>
> ? (note sure how cmd_iu is being initialized, but given that the other fields
> around this code are assigned 0, I would guess this one needs that as well...)
>

Yeah, I think that you are right - I'll fix that up. Thanks for checking
very carefully.

John