From: Hannes Reinecke <hare@suse.de>
To: James Smart <jsmart2021@gmail.com>, linux-scsi@vger.kernel.org
Cc: Dick Kennedy <dick.kennedy@broadcom.com>
Subject: Re: [PATCH 1/9] lpfc: Synchronize NVME transport and lpfc driver devloss_tmo
Date: Thu, 7 May 2020 11:11:53 +0200 [thread overview]
Message-ID: <bfa15c96-b1a0-384d-e59d-a9792dc77bdf@suse.de> (raw)
In-Reply-To: <20200501214310.91713-2-jsmart2021@gmail.com>
On 5/1/20 11:43 PM, James Smart wrote:
> The driver is not passing it's devloss tmo to the nvme-fc transport when
> registering the remote port. Thus devloss tmo for the nvme-fc remote port
> will be set to the transport's default. This causes driver actions to be
> out of sync with transport actions and out of sync with scsi actions for
> perhaps the same remote port.
>
> This is especially notable in the following scenario: while remote port
> is attached, devloss is changed globally for lpfc remote ports via lpfc
> sysfs parameter. lpfc ties this change in with nvme-fc transport. If the
> device disconnects long enough for devloss to expire thus the existing
> remote port is deleted, then the remote port is re-discovered, the newly
> created remote port will end up set at the transport default, not lpfc's
> value.
>
> Fix by setting devloss tmo value when registering the remote port.
>
> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_nvme.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c
> index 12d2b2775773..43df08aeecf1 100644
> --- a/drivers/scsi/lpfc/lpfc_nvme.c
> +++ b/drivers/scsi/lpfc/lpfc_nvme.c
> @@ -2296,6 +2296,7 @@ lpfc_nvme_register_port(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp)
>
> rpinfo.port_name = wwn_to_u64(ndlp->nlp_portname.u.wwn);
> rpinfo.node_name = wwn_to_u64(ndlp->nlp_nodename.u.wwn);
> + rpinfo.dev_loss_tmo = vport->cfg_devloss_tmo;
>
> spin_lock_irq(&vport->phba->hbalock);
> oldrport = lpfc_ndlp_get_nrport(ndlp);
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2020-05-07 9:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 21:43 [PATCH 0/9] lpfc: Update lpfc to revision 12.8.0.1 James Smart
2020-05-01 21:43 ` [PATCH 1/9] lpfc: Synchronize NVME transport and lpfc driver devloss_tmo James Smart
2020-05-03 14:42 ` James Smart
2020-05-07 9:11 ` Hannes Reinecke [this message]
2020-05-01 21:43 ` [PATCH 2/9] lpfc: Maintain atomic consistency of queue_claimed flag James Smart
2020-05-07 9:12 ` Hannes Reinecke
2020-05-01 21:43 ` [PATCH 3/9] lpfc: Remove re-binding of nvme rport during registration James Smart
2020-05-07 9:13 ` Hannes Reinecke
2020-05-01 21:43 ` [PATCH 4/9] lpfc: Fix negation of else clause in lpfc_prep_node_fc4type James Smart
2020-05-07 9:14 ` Hannes Reinecke
2020-05-01 21:43 ` [PATCH 5/9] lpfc: Change default queue allocation for reduced memory consumption James Smart
2020-05-07 9:49 ` Hannes Reinecke
2020-05-01 21:43 ` [PATCH 6/9] lpfc: Remove unnecessary lockdep_assert_held calls James Smart
2020-05-07 9:50 ` Hannes Reinecke
2020-05-01 21:43 ` [PATCH 7/9] lpfc: Fix noderef and address space warnings James Smart
2020-05-07 9:50 ` Hannes Reinecke
2020-05-01 21:43 ` [PATCH 8/9] lpfc: Fix MDS Diagnostic Enablement definition James Smart
2020-05-07 9:50 ` Hannes Reinecke
2020-05-01 21:43 ` [PATCH 9/9] lpfc: Update lpfc version to 12.8.0.1 James Smart
2020-05-07 9:51 ` Hannes Reinecke
2020-05-08 2:54 ` [PATCH 0/9] lpfc: Update lpfc to revision 12.8.0.1 Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfa15c96-b1a0-384d-e59d-a9792dc77bdf@suse.de \
--to=hare@suse.de \
--cc=dick.kennedy@broadcom.com \
--cc=jsmart2021@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox