From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org,
Sathya Prakash <sathya.prakash@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Subject: Re: [PATCH] scsi: mpi3mr: Fix SATA NCQ priority support
Date: Fri, 7 Jun 2024 08:16:43 +0900 [thread overview]
Message-ID: <bff737e3-ce5a-40c8-a447-249b26540930@kernel.org> (raw)
In-Reply-To: <ZmGs2wZDO9ZTO0s4@infradead.org>
On 6/6/24 21:34, Christoph Hellwig wrote:
> On Thu, Jun 06, 2024 at 09:14:46PM +0900, Damien Le Moal wrote:
>> "also" ? your previous point was not about this function ?
>
> No, about all the attribute boilerplate code.
Yeah. That boilerplate for the 2 drivers differ only with the internal data
structure used to store the cdl_enable boolean. So I guess we could make these
attributes more generic.
Ideally though, we should do something similar to CDL and have scsi layer deal
with that automatically to avoid SAS drivers to have to do that themselves. And
libata also has the same attributes.
I would like to get this fix in ASAP as I am getting reports back from the field
of NCQ priority not working with mpi3mr. I can send a cleanup series for the
attributes on top of this fix later if that is OK with you.
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2024-06-06 23:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 5:47 [PATCH] scsi: mpi3mr: Fix SATA NCQ priority support Damien Le Moal
2024-06-06 9:31 ` Christoph Hellwig
2024-06-06 12:14 ` Damien Le Moal
2024-06-06 12:34 ` Christoph Hellwig
2024-06-06 23:16 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bff737e3-ce5a-40c8-a447-249b26540930@kernel.org \
--to=dlemoal@kernel.org \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox