[Bug 13437] New: found overlapping data buffer

[Bug 13437] New: found overlapping data buffer

[bugzilla-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=13437

           Summary: found overlapping data buffer
           Product: SCSI Drivers
           Version: 2.5
    Kernel Version: 2.6.29.3
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: GDT SCSI
        AssignedTo: scsi_drivers-gdt-scsi@kernel-bugs.osdl.org
        ReportedBy: ettl.martin@gmx.de
        Regression: No


Hello,

i detected an overlapping data buffer at file
"linux-2.6.29.3/drivers/scsi/gdth_proc.c"
For detection, i used the static code analysis tool cppcheck. It prints the
following message:
[linux-2.6.29.3/drivers/scsi/gdth_proc.c:199]: (error) Overlapping data buffer
hrec

Take a loop at file gdth_proc.c at line 199:

            sprintf(hrec,"%s,%d", hrec, reserve_list[i]);

Here, hrec is used by iteself at the sprintf statement, this is dangerous!!!!

Best regards

Ettl Martin

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 13437] found overlapping data buffer

[bugzilla-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=13437


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |alan@lxorguk.ukuu.org.uk
         Resolution|                            |CODE_FIX




-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 13437] found overlapping data buffer

[bugzilla-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=13437


Marc Bejarano <bugzilla.kernel.org@beej.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla.kernel.org@beej.or
                   |                            |g




--- Comment #1 from Marc Bejarano <bugzilla.kernel.org@beej.org>  2009-06-18 03:09:24 ---
alan: have a commit id for the fix handy?

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 13437] found overlapping data buffer

[bugzilla-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=13437





--- Comment #2 from Marc Bejarano <bugzilla.kernel.org@beej.org>  2009-06-18 04:50:40 ---
patch: http://permalink.gmane.org/gmane.linux.scsi/51819

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 13437] found overlapping data buffer

[bugzilla-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=13437


Martin Ettl <ettl.martin@gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED
         Resolution|CODE_FIX                    |PATCH_ALREADY_AVAILABLE




--- Comment #3 from Martin Ettl <ettl.martin@gmx.de>  2009-06-18 07:57:41 ---
To my mind, this can be closed here.

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 13437] found overlapping data buffer

[bugzilla-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=13437


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|PATCH_ALREADY_AVAILABLE     |CODE_FIX




-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.