linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: linux-scsi@vger.kernel.org
Subject: [Bug 13519] New: Syntax error. Not enough parameters for macro 'qla_printk'.
Date: Fri, 12 Jun 2009 12:25:13 GMT	[thread overview]
Message-ID: <bug-13519-11613@http.bugzilla.kernel.org/> (raw)

http://bugzilla.kernel.org/show_bug.cgi?id=13519

           Summary: Syntax error. Not enough parameters for macro
                    'qla_printk'.
           Product: SCSI Drivers
           Version: 2.5
    Kernel Version: 2.6.30
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: QLOGIC QLA2XXX
        AssignedTo: scsi_drivers-qla2xxx@kernel-bugs.osdl.org
        ReportedBy: ettl.martin@gmx.de
        Regression: No


Hi,

i have detected a wrong macro call in file qla_sup.c. To detect this issue i
used the static code analysis tool cppcheck. It prints the following output:

[linux-2.6.30/drivers/scsi/qla2xxx/qla_sup.c:352]: (error) Syntax error. Not
enough parameters for macro 'qla_printk'.

Take a look at file qla_sup.c line 352 

                DEBUG9_10(qla_printk(
                    "NVRAM didn't go ready...\n"));


The maro definition is in file qla_def.h (2657):

#define qla_printk(level, ha, format, arg...) \
    dev_printk(level , &((ha)->pdev->dev) , format , ## arg)

As you can see, it needs more than one parameter.

Best regards

Ettl Martin

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

             reply	other threads:[~2009-06-12 12:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-12 12:25 bugzilla-daemon [this message]
2009-06-12 12:32 ` [Bug 13519] New: Syntax error. Not enough parameters for macro 'qla_printk' Matthew Wilcox
2009-06-12 12:32 ` [Bug 13519] " bugzilla-daemon
2009-06-12 12:35 ` bugzilla-daemon
2009-06-29 11:50 ` bugzilla-daemon
2009-06-29 11:50 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-13519-11613@http.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).