[Bug 188061] New: On quad port QLE2564 can't add in target only 2 ports

[Bug 188061] New: On quad port QLE2564 can't add in target only 2 ports

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=188061

            Bug ID: 188061
           Summary: On quad port QLE2564 can't add in target only 2 ports
           Product: SCSI Drivers
           Version: 2.5
    Kernel Version: 4.8.6-201.fc24.x86_64
          Hardware: x86-64
                OS: Linux
              Tree: Fedora
            Status: NEW
          Severity: normal
          Priority: P1
         Component: QLOGIC QLA2XXX
          Assignee: scsi_drivers-qla2xxx@kernel-bugs.osdl.org
          Reporter: anthony.bloodoff@gmail.com
        Regression: No

I have QLE2564 (quad port) with portnames:
09:00.0 Fibre Channel: QLogic Corp. ISP2532-based 8Gb Fibre Channel to PCI
Express HBA (rev 02)
09:00.1 Fibre Channel: QLogic Corp. ISP2532-based 8Gb Fibre Channel to PCI
Express HBA (rev 02)
0a:00.0 Fibre Channel: QLogic Corp. ISP2532-based 8Gb Fibre Channel to PCI
Express HBA (rev 02)
0a:00.1 Fibre Channel: QLogic Corp. ISP2532-based 8Gb Fibre Channel to PCI
Express HBA (rev 02)

systool -c fc_host -v | grep port_name
    port_name           = "0x15b0024ffaa536f"
    port_name           = "0x115b0024ffaa536f"
    port_name           = "0x215b0024ffaa536f"
    port_name           = "0x315b0024ffaa536f"
Same info from targetcli:
/qla2xxx> info 
Fabric module name: qla2xxx
ConfigFS path: /sys/kernel/config/target/qla2xxx
Allowed WWN types: naa
Allowed WWNs list: naa.215b0024ffaa536f, naa.15b0024ffaa536f,
naa.315b0024ffaa536f, naa.115b0024ffaa536f
Fabric module features: acls
Corresponding kernel module: tcm_qla2xxx

2 NAA I have succefully added:
naa.115b0024ffaa536f
naa.215b0024ffaa536f

but other two fails:
/qla2xxx> create naa.315b0024ffaa536f 
WWN not valid as: naa

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 188061] On quad port QLE2564 can't add in target only 2 ports

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=188061

himanshu.madhani@cavium.com <himanshu.madhani@qlogic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |himanshu.madhani@qlogic.com

--- Comment #1 from himanshu.madhani@cavium.com <himanshu.madhani@qlogic.com> ---
Hello, 

What is version of targetcli version used here?. Also can you provide message
file when this error is seen.

Thanks,
-Himanshu

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 188061] On quad port QLE2564 can't add in target only 2 ports

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=188061

--- Comment #2 from Anthony <anthony.bloodoff@gmail.com> ---
targetcli-2.1.fb43-2.fc25.noarch
python3-rtslib-2.1.fb60-2.fc25.noarch

I found possible reason and ugly workaround:
in package RTSLib file utils.py change REGEXP to validate WWN

'naa': lambda wwn: re.match("naa\.[1235][0-9a-fA-F]{15}$", wwn),

but I can't understnad why my QLogic card uses strange port names:
0x15b0024ffaa536f and 0x315b0024ffaa536f
and why on quad ports card from port to port changes highest bit in portname

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 188061] On quad port QLE2564 can't add in target only 2 ports

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=188061

--- Comment #3 from himanshu.madhani@cavium.com <himanshu.madhani@qlogic.com> ---
I would not know that part but from drive point of view any valid WWN should be
fine.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 188061] On quad port QLE2564 can't add in target only 2 ports

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=188061

--- Comment #4 from Anthony <anthony.bloodoff@gmail.com> ---
>From rtslib (naa wwn must start with 1 or 2 or 5):

def normalize_wwn(wwn_types, wwn):
    '''
    Take a WWN as given by the user and convert it to a standard text
    representation.

    Returns (normalized_wwn, wwn_type), or exception if invalid wwn.
    '''
    wwn_test = {
    'free': lambda wwn: True,
    'iqn': lambda wwn: \
        re.match("iqn\.[0-9]{4}-[0-1][0-9]\..*\..*", wwn) \
        and not re.search(' ', wwn) \
        and not re.search('_', wwn),
    'naa': lambda wwn: re.match("naa\.[125][0-9a-fA-F]{15}$", wwn),
    'eui': lambda wwn: re.match("eui\.[0-9a-f]{16}$", wwn),
    'ib': lambda wwn: re.match("ib\.[0-9a-f]{32}$", wwn),
    'unit_serial': lambda wwn: \
        re.match("[0-9A-Fa-f]{8}(-[0-9A-Fa-f]{4}){3}-[0-9A-Fa-f]{12}$", wwn),
    }

    for wwn_type in wwn_types:
        clean_wwn = _cleanse_wwn(wwn_type, wwn)
        found_type = wwn_test[wwn_type](clean_wwn)
        if found_type:
            break
    else:
        raise RTSLibError("WWN not valid as: %s" % ", ".join(wwn_types))

    return (clean_wwn, wwn_type)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 188061] On quad port QLE2564 can't add in target only 2 ports

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=188061

--- Comment #5 from Anthony (anthony.bloodoff@gmail.com) ---
I've installed another 4-port card and got same issue - port names have
variable part at highest bits. On 2-port card port names have variable part at
lower bits:
    port_name           = "0x21000024ff3bcb3e"
    port_name           = "0x21000024ff3bcb3f"
I'm trying to change a port name in NVRAM with FLASUTIL.EXE with no luck.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 188061] On quad port QLE2564 can't add in target only 2 ports

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=188061

--- Comment #6 from himanshu.madhani@cavium.com (himanshu.madhani@qlogic.com) ---
(In reply to Anthony from comment #5)
> I've installed another 4-port card and got same issue - port names have
> variable part at highest bits. On 2-port card port names have variable part
> at lower bits:
>     port_name           = "0x21000024ff3bcb3e"
>     port_name           = "0x21000024ff3bcb3f"
> I'm trying to change a port name in NVRAM with FLASUTIL.EXE with no luck.

Hi Anthony, 

Can you please attach output of following command from your 4-port card.

# lspci -vvv -s <pci_bus_for_each_port>

So for example 

# lspci -vvv -s 09.00.0 and so on for each of the 4 ports of 4-port card. 

Thanks,
Himanshu

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 188061] On quad port QLE2564 can't add in target only 2 ports

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=188061

--- Comment #7 from Anthony (anthony.bloodoff@gmail.com) ---
Created attachment 255073
  --> https://bugzilla.kernel.org/attachment.cgi?id=255073&action=edit
Output lspci for 4-port card

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 188061] On quad port QLE2564 can't add in target only 2 ports

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=188061

--- Comment #8 from Anthony (anthony.bloodoff@gmail.com) ---
I added output in text attachment. By construction this card have 3 PCI-E
switches onboard.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 188061] On quad port QLE2564 can't add in target only 2 ports

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=188061

--- Comment #9 from himanshu.madhani@cavium.com (himanshu.madhani@qlogic.com) ---
(In reply to Anthony from comment #8)
> I added output in text attachment. By construction this card have 3 PCI-E
> switches onboard.

Checking with our hardware/firmware team on what is going on with these cards. 

Thanks,
Himanshu

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 188061] On quad port QLE2564 can't add in target only 2 ports

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=188061

--- Comment #10 from Anthony (anthony.bloodoff@gmail.com) ---
Problem does not change with kernel updates. Any news about firmware?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.