[Bug 42142] New: mpt2sas: Number specified in wrong base.

[Bug 42142] New: mpt2sas: Number specified in wrong base.

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=42142

           Summary: mpt2sas: Number specified in wrong base.
           Product: SCSI Drivers
           Version: 2.5
    Kernel Version: 3.0.4
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: low
          Priority: P1
         Component: Other
        AssignedTo: scsi_drivers-other@kernel-bugs.osdl.org
        ReportedBy: daniel.kernel@the-cell.co.uk
        Regression: No


I think this is the right product/component combination, sorry if it isn't.

I was hunting through mpt2sas chasing unrelated hardware gremlins and noticed
an odd bit of code, I've checked the latest version on lxr and it's still
there.

http://lxr.linux.no/linux+v3.0.4/drivers/scsi/mpt2sas/mpt2sas_base.c#L611

 611        /* eat the loginfos associated with task aborts */
 612        if (ioc->ignore_loginfos && (log_info == 30050000 || log_info ==
 613            0x31140000 || log_info == 0x31130000))
 614                return;
 615

I'm assuming that the first of those log_info checks is meant to be 0x30050000,
as specified it is rendered always false by the bus type check a few lines
above.

It's a minor detail, but I thought I'd report it anyway since it's so trivial
to fix if you have the source to hand.

Regards,
Daniel

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 42142] mpt2sas: Number specified in wrong base.

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=42142


Florian Mickler <florian@mickler.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |florian@mickler.org




--- Comment #1 from Florian Mickler <florian@mickler.org>  2012-04-04 15:04:18 ---
A patch referencing this bug report has been merged in Linux v3.4-rc1:

commit 714be35885093305b7491cc3eea959bb3e1be6f2
Author: Sathisha Nanjappa <sathisha.nanjappa@hp.com>
Date:   Tue Mar 13 11:59:28 2012 -0700

    [SCSI] mpt2sas: remove extraneous sas_log_info messages

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 42142] mpt2sas: Number specified in wrong base.

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=42142


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |alan@lxorguk.ukuu.org.uk
         Resolution|                            |CODE_FIX




-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 42142] mpt2sas: Number specified in wrong base.

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=42142


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.