* [Bug 67091] scsi/be2iscsi/be_main.c:328: possible bad if expression ?
[not found] <bug-67091-11613@https.bugzilla.kernel.org/>
@ 2013-12-18 14:24 ` bugzilla-daemon
2013-12-19 7:16 ` Mike Christie
0 siblings, 1 reply; 2+ messages in thread
From: bugzilla-daemon @ 2013-12-18 14:24 UTC (permalink / raw)
To: linux-scsi
https://bugzilla.kernel.org/show_bug.cgi?id=67091
Alan <alan@lxorguk.ukuu.org.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |alan@lxorguk.ukuu.org.uk
Component|Other |Other
Assignee|drivers_other@kernel-bugs.o |scsi_drivers-other@kernel-b
|sdl.org |ugs.osdl.org
Product|Drivers |SCSI Drivers
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Bug 67091] scsi/be2iscsi/be_main.c:328: possible bad if expression ?
2013-12-18 14:24 ` [Bug 67091] scsi/be2iscsi/be_main.c:328: possible bad if expression ? bugzilla-daemon
@ 2013-12-19 7:16 ` Mike Christie
0 siblings, 0 replies; 2+ messages in thread
From: Mike Christie @ 2013-12-19 7:16 UTC (permalink / raw)
To: bugzilla-daemon; +Cc: linux-scsi, Jayamohan.Kallickal@Emulex.Com
On 12/18/2013 08:24 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=67091
>
> Alan <alan@lxorguk.ukuu.org.uk> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> CC| |alan@lxorguk.ukuu.org.uk
> Component|Other |Other
> Assignee|drivers_other@kernel-bugs.o |scsi_drivers-other@kernel-b
> |sdl.org |ugs.osdl.org
> Product|Drivers |SCSI Drivers
>
Jay,
I thought we fixed that bug. I am not seeing a patch though. I think we
wanted to be checking against the sc passed in. Patch is compile tested
only.
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 1f37505..5642a9b 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -325,7 +325,7 @@ static int beiscsi_eh_device_reset(struct scsi_cmnd *sc)
if (!abrt_task->sc || abrt_task->state == ISCSI_TASK_FREE)
continue;
- if (abrt_task->sc->device->lun != abrt_task->sc->device->lun)
+ if (sc->device->lun != abrt_task->sc->device->lun)
continue;
/* Invalidate WRB Posted for this Task */
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-19 7:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <bug-67091-11613@https.bugzilla.kernel.org/>
2013-12-18 14:24 ` [Bug 67091] scsi/be2iscsi/be_main.c:328: possible bad if expression ? bugzilla-daemon
2013-12-19 7:16 ` Mike Christie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).