From: Bart Van Assche <bvanassche@acm.org>
To: Mike Christie <michael.christie@oracle.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
snitzer@kernel.org, hch@lst.de, axboe@kernel.dk,
martin.petersen@oracle.com,
james.bottomley@hansenpartnership.com,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [dm-devel] [PATCH 09/11] block, nvme: Add error for reservation conflicts.
Date: Sat, 4 Jun 2022 21:00:01 -0700 [thread overview]
Message-ID: <c026fa1e-cca1-08c3-5d99-81ec79d8d343@acm.org> (raw)
In-Reply-To: <20220603065536.5641-10-michael.christie@oracle.com>
On 6/2/22 23:55, Mike Christie wrote:
> BLK_STS_NEXUS is used for nvme/scsi reservation conflicts and also
> general nexus failures. For the pr_ops use we want to know if an IO failed
> for specifically a reservation conflict so we can report that error upwards
> to a VM. This patch adds a new error code for this case and converts nvme.
> The next patch converts scsi because it's a little more complicated.
>
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
> block/blk-core.c | 1 +
> drivers/nvme/host/core.c | 2 +-
> include/linux/blk_types.h | 4 ++++
> 3 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/block/blk-core.c b/block/blk-core.c
> index bc0506772152..3908ac4a70b6 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -171,6 +171,7 @@ static const struct {
> /* zone device specific errors */
> [BLK_STS_ZONE_OPEN_RESOURCE] = { -ETOOMANYREFS, "open zones exceeded" },
> [BLK_STS_ZONE_ACTIVE_RESOURCE] = { -EOVERFLOW, "active zones exceeded" },
> + [BLK_STS_RSV_CONFLICT] = { -EBADE, "resevation conflict" },
^^^^^^^^^^
Please fix the spelling of "reservation".
Thanks,
Bart.
next prev parent reply other threads:[~2022-06-05 4:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 6:55 [PATCH 0/8] Use block pr_ops in LIO Mike Christie
2022-06-03 6:55 ` [PATCH 01/11] scsi: target: Rename sbc_ops to exec_cmd_ops Mike Christie
2022-06-20 7:12 ` Christoph Hellwig
2022-06-03 6:55 ` [PATCH 02/11] scsi: Rename sd_pr_command Mike Christie
2022-06-20 7:13 ` Christoph Hellwig
2022-06-03 6:55 ` [PATCH 03/11] scsi: Move sd_pr_type to header to share Mike Christie
2022-06-05 3:58 ` Bart Van Assche
2022-06-20 7:13 ` Christoph Hellwig
2022-06-03 6:55 ` [PATCH 04/11] block: Add PR callouts for read keys and reservation Mike Christie
2022-06-20 7:14 ` Christoph Hellwig
2022-06-03 6:55 ` [PATCH 05/11] scsi: Add support for block PR read keys/reservation Mike Christie
2022-06-03 6:55 ` [PATCH 06/11] dm: " Mike Christie
2022-06-03 6:55 ` [PATCH 07/11] scsi: target: Allow backends to hook into PR handling Mike Christie
2022-06-20 7:15 ` Christoph Hellwig
2022-06-03 6:55 ` [PATCH 08/11] scsi: target: Add block PR support to iblock Mike Christie
2022-06-20 7:18 ` Christoph Hellwig
2022-06-03 6:55 ` [PATCH 09/11] block, nvme: Add error for reservation conflicts Mike Christie
2022-06-03 19:45 ` Keith Busch
2022-06-03 23:08 ` Mike Christie
2022-06-04 7:38 ` Hannes Reinecke
2022-06-04 17:13 ` michael.christie
2022-06-05 9:42 ` Hannes Reinecke
2022-06-20 7:23 ` Christoph Hellwig
2022-06-05 4:00 ` Bart Van Assche [this message]
2022-06-03 6:55 ` [PATCH 10/11] scsi: Use BLK_STS_RSV_CONFLICT " Mike Christie
2022-06-03 6:55 ` [PATCH 11/11] scsi: target: Handle BLK_STS_RSV_CONFLICT Mike Christie
2022-06-03 11:46 ` [PATCH 0/8] Use block pr_ops in LIO Christoph Hellwig
2022-06-03 17:55 ` Mike Christie
2022-06-20 7:12 ` Christoph Hellwig
2022-06-05 4:01 ` [dm-devel] " Bart Van Assche
2022-06-05 16:55 ` Mike Christie
2022-06-05 18:15 ` Bart Van Assche
2022-06-06 16:38 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c026fa1e-cca1-08c3-5d99-81ec79d8d343@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=snitzer@kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox