From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF3631A7264; Wed, 8 Jan 2025 07:19:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736320763; cv=none; b=a6btawuBvhrqBJ6Oo5f4slmX5kP5vqvAFis36FY9mybHcKGq4uomFMiKPxmXKWCK8i2z3CR1FMNrF7SI+NilleVwTkiBnbgAT06haPC85icbdGHEDYqNAzA62ik0b+SgJ/U+XiBlyKZDAWRONCm++68AbUnZ06SF6w7SqnCyhsE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736320763; c=relaxed/simple; bh=2OmpbwECjc3ztteZgZS83w5ZYoOVpKG0/XhfbIN52io=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O0WT1T7IwEUboszs6/fnmP0u9Zgx/3VWDRPbZ/eGjU1HM9Zff1wTdLzWixcMlLPMBBsXCNxNW/JxlMe5AfSftUSqpyw8sg6PNT4HEF57c/ZKBXZRdh8pmKLMdjtw9h9S4mCC8+cD6VMp2caWVXARo15d2R8qj0C8nNGT+a6+i3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=YHtY3luf; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=4OaKIcLN; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=U8BlRzIZ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=qRu/+kJi; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="YHtY3luf"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="4OaKIcLN"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="U8BlRzIZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="qRu/+kJi" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EB00C21109; Wed, 8 Jan 2025 07:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1736320760; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UMHSN1RUI191v0AL+xJ8VycN40kw5fLrPVaLypzjD+E=; b=YHtY3lufWWZVElyJtifBFzBtdrFMEJFsJfjmrAPgUD2ZAe/Ct5BA8ENg1wKRwTBZKfoKpF q/gD+XWMMSROgUZbXOEVFhvTcYym/Fj5JF+JxAWq7jH79ASW7ljR9BJq2cs+xQqCnGsGcj RpnVfdNMKQ7oNW3k1AfwNHCWrhrp9M0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1736320760; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UMHSN1RUI191v0AL+xJ8VycN40kw5fLrPVaLypzjD+E=; b=4OaKIcLN+9VWhR6Mn7PYR6Vje53hndZu7LNwssLmjKwu7KPIrWMVLYoGyk9gTj9Kkd5A63 aGWBQYpTPddefcBw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1736320759; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UMHSN1RUI191v0AL+xJ8VycN40kw5fLrPVaLypzjD+E=; b=U8BlRzIZ3xaDo2aiJn88NeswoYKPmsMcBAwE6GhQr3dBhr/XwT6dbRUDHaMPmgMGaajzY/ La2CUU40RaUCepVxhb/CaT++R7ur/o0LLCRuaDeLTVc6aad+hSGOdn/1oj5AsZU4IBdi98 U19iOzSpLPjQg/9PnjHieGftnpNNDak= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1736320759; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UMHSN1RUI191v0AL+xJ8VycN40kw5fLrPVaLypzjD+E=; b=qRu/+kJigVE6teuHtYZdh+XkEMgI/J3KKinf+oiu/1W7kjTtPtxYZgfZfrVAoRac5R9z6k nN+3Te5i303osNAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E16A9137DA; Wed, 8 Jan 2025 07:19:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ChdINPUmfme7QAAAD6G6ig (envelope-from ); Wed, 08 Jan 2025 07:19:17 +0000 Message-ID: Date: Wed, 8 Jan 2025 08:19:17 +0100 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/9] nvme-pci: use block layer helpers to calculate num of queues To: Daniel Wagner , Jens Axboe , Keith Busch , Christoph Hellwig , Sagi Grimberg , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , "Martin K. Petersen" , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, Don Brace , "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Xuan Zhuo , Andrew Morton , Thomas Gleixner Cc: Costa Shulyupin , Juri Lelli , Valentin Schneider , Waiman Long , Ming Lei , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Frederic Weisbecker , Mel Gorman , Sridhar Balaraman , "brookxu.cn" , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, storagedev@microchip.com, virtualization@lists.linux.dev References: <20241217-isolcpus-io-queues-v4-0-5d355fbb1e14@kernel.org> <20241217-isolcpus-io-queues-v4-4-5d355fbb1e14@kernel.org> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20241217-isolcpus-io-queues-v4-4-5d355fbb1e14@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; TAGGED_RCPT(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_TWELVE(0.00)[38]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[redhat.com,suse.com,kernel.org,suse.de,parallelwireless.com,gmail.com,vger.kernel.org,lists.infradead.org,broadcom.com,microchip.com,lists.linux.dev]; R_RATELIMIT(0.00)[to_ip_from(RLwoqrtcdrtewo8fubna94zinu)]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo] X-Spam-Flag: NO X-Spam-Level: On 12/17/24 19:29, Daniel Wagner wrote: > Multiqueue devices should only allocate queues for the housekeeping CPUs > when isolcpus=managed_irq is set. This avoids that the isolated CPUs get > disturbed with OS workload. > > Use helpers which calculates the correct number of queues which should > be used when isolcpus is used. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Daniel Wagner > --- > drivers/nvme/host/pci.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich