From: Bart Van Assche <bvanassche@acm.org>
To: "Rob Herring (Arm)" <robh@kernel.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ufs: ufshcd: Use of_property_count_u32_elems() to get property length
Date: Wed, 31 Jul 2024 14:06:59 -0700 [thread overview]
Message-ID: <c27e1eb8-e5e5-4b3c-a792-c447023709bf@acm.org> (raw)
In-Reply-To: <20240731201407.1838385-9-robh@kernel.org>
On 7/31/24 1:14 PM, Rob Herring (Arm) wrote:
> Replace of_get_property() with the type specific
> of_property_count_u32_elems() to get the property length.
>
> This is part of a larger effort to remove callers of of_get_property()
> and similar functions. of_get_property() leaks the DT property data
> pointer which is a problem for dynamically allocated nodes which may
> be freed.
The "ufshcd:" qualifier in the patch subject is confusing. Please change
this into something that unambiguously refers to the platform driver.
Thanks,
Bart.
prev parent reply other threads:[~2024-07-31 21:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 20:14 [PATCH] ufs: ufshcd: Use of_property_count_u32_elems() to get property length Rob Herring (Arm)
2024-07-31 21:06 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c27e1eb8-e5e5-4b3c-a792-c447023709bf@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox