From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bryant G. Ly" Subject: Re: [PATCH 1/6] target: Fix QUEUE_FULL + SCSI task attribute handling Date: Wed, 8 Nov 2017 15:29:45 -0600 Message-ID: References: <1510115512-15617-1-git-send-email-nab@linux-iscsi.org> <1510115512-15617-2-git-send-email-nab@linux-iscsi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1510115512-15617-2-git-send-email-nab@linux-iscsi.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: "Nicholas A. Bellinger" , target-devel Cc: linux-scsi , lkml , Michael Cyr , Mike Christie , Hannes Reinecke List-Id: linux-scsi@vger.kernel.org > From: Nicholas Bellinger > > This patch fixes a bug during QUEUE_FULL where transport_complete_qf() > calls transport_complete_task_attr() after it's already been invoked > by target_complete_ok_work() or transport_generic_request_failure() > during initial completion, preceeding QUEUE_FULL. > > This will result in se_device->simple_cmds, se_device->dev_cur_ordered_id > and/or se_device->dev_ordered_sync being updated multiple times for > a single se_cmd. > > To address this bug, clear SCF_TASK_ATTR_SET after the first call > to transport_complete_task_attr(), and avoid updating SCSI task > attribute related counters for any subsequent calls. > > Also, when a se_cmd is deferred due to ordered tags and executed > via target_restart_delayed_cmds(), set CMD_T_SENT before execution > matching what target_execute_cmd() does. > > Cc: Michael Cyr > Cc: Bryant G. Ly > Cc: Mike Christie > Cc: Hannes Reinecke > Signed-off-by: Nicholas Bellinger > --- > Reviewed-by: Bryant G. Ly