From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25673C33CAF for ; Sun, 19 Jan 2020 20:40:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F0AC7206ED for ; Sun, 19 Jan 2020 20:40:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728712AbgASUkV (ORCPT ); Sun, 19 Jan 2020 15:40:21 -0500 Received: from mail-pj1-f67.google.com ([209.85.216.67]:36595 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728682AbgASUkV (ORCPT ); Sun, 19 Jan 2020 15:40:21 -0500 Received: by mail-pj1-f67.google.com with SMTP id n59so6052663pjb.1; Sun, 19 Jan 2020 12:40:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=xDGjbpMkljE0bvXrsbhUGFiOois6V5ZUiWgVlN1KnsE=; b=XxQTBC3Cob8vFEApSz/chXGMjvF82OpTtzEc/ssyOjCHoT/0yhrBY81qyqzooDvVHB /QW767T/eSK96EzGR7YPyhejn+2S9aTG41/kBiyn9I2clhbX5VNTa1U+yc0XITg173iw 06TkKfyBoX1kv0zmI9rIRDpBkVREHqhajQ7P8ZwyjF59O/3VtK/EKbeUMPPg0yjvLqqQ oFvuGLPI8LsrFbz95k52yDn/4K9bkbQp36plKqllhBE8PU37Z6T5WMm3LWoIaJicswM4 cXfkViL0XXd1+j/W22PYyqWnYEoScTr4JmdmP36IZVQy1GTvrxNNOWOILd0iTC2lVnD9 WjqA== X-Gm-Message-State: APjAAAURvYMHWWknt+7oPpWP53iUKAI9mssxFxmvmE97bgUwmPNy8tyw NjhkGikHybApSOFGVR3q3GE= X-Google-Smtp-Source: APXvYqxQPZ3Vg+vVtcQtiAVIEDIdZ0rVzr4pMrsH7GmOf8lVYu78a0qE5FW25Mz1sV89TpshXPfOvQ== X-Received: by 2002:a17:902:aa96:: with SMTP id d22mr11318440plr.204.1579466420530; Sun, 19 Jan 2020 12:40:20 -0800 (PST) Received: from ?IPv6:2601:647:4000:d7:781f:ca33:6085:f83a? ([2601:647:4000:d7:781f:ca33:6085:f83a]) by smtp.gmail.com with ESMTPSA id b1sm26540813pfp.44.2020.01.19.12.40.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Jan 2020 12:40:19 -0800 (PST) Subject: Re: [PATCH 4/6] block: freeze queue for updating QUEUE_FLAG_NONROT To: Ming Lei , James Bottomley , linux-scsi@vger.kernel.org, "Martin K . Petersen" Cc: linux-block@vger.kernel.org, Jens Axboe , Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , Kashyap Desai , Sumit Saxena , Shivasharan S , "Ewan D . Milne" , Christoph Hellwig , Hannes Reinecke , Bart Van Assche References: <20200119071432.18558-1-ming.lei@redhat.com> <20200119071432.18558-5-ming.lei@redhat.com> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: Date: Sun, 19 Jan 2020 12:40:18 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200119071432.18558-5-ming.lei@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2020-01-18 23:14, Ming Lei wrote: > +static ssize_t queue_store_nonrot_freeze(struct request_queue *q, > + const char *page, size_t count) > +{ > + size_t ret; > + > + blk_mq_freeze_queue(q); > + ret = queue_store_nonrot(q, page, count); > + blk_mq_unfreeze_queue(q); > + > + return ret; > +} Both queue_store_nonrot() and queue_store_nonrot_freeze() return a signed integer but 'ret' is an unsigned integer. Is that perhaps the result of an oversight? Thanks, Bart.