Re: [PATCH 2/2] scsi: bsg: Pass dev to blk_mq_alloc_queue()

[Hannes Reinecke <hare@suse.de>]

On 5/24/24 10:48, John Garry wrote:
> When calling bsg_setup_queue() -> blk_mq_alloc_queue(), we don't pass
> the dev as the queuedata, but rather manually set it afterwards. Just
> pass dev to blk_mq_alloc_queue() to have automatically set.
> 
> Signed-off-by: John Garry <john.g.garry@oracle.com>
> ---
>   block/bsg-lib.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/block/bsg-lib.c b/block/bsg-lib.c
> index ee738d129a9f..32da4a4429ce 100644
> --- a/block/bsg-lib.c
> +++ b/block/bsg-lib.c
> @@ -385,13 +385,12 @@ struct request_queue *bsg_setup_queue(struct device *dev, const char *name,
>   	if (blk_mq_alloc_tag_set(set))
>   		goto out_tag_set;
>   
> -	q = blk_mq_alloc_queue(set, lim, NULL);
> +	q = blk_mq_alloc_queue(set, lim, dev);
>   	if (IS_ERR(q)) {
>   		ret = PTR_ERR(q);
>   		goto out_queue;
>   	}
>   
> -	q->queuedata = dev;
>   	blk_queue_rq_timeout(q, BLK_DEFAULT_SG_TIMEOUT);
>   
>   	bset->bd = bsg_register_queue(q, dev, name, bsg_transport_sg_io_fn);

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes