Re: [PATCH v1 6/7] mpi3mr: Record and report controller firmware faults

[Damien Le Moal <dlemoal@kernel.org>]

On 1/12/26 09:10, Ranjan Kumar wrote:
> +static void mpi3mr_fault_uevent_emit(struct mpi3mr_ioc *mrioc)
> +{
> +	struct kobj_uevent_env *env;
> +
> +	env = kzalloc(sizeof(*env), GFP_KERNEL);
> +	if (!env)
> +		return;
> +
> +	if (add_uevent_var(env, "DRIVER=%s", mrioc->driver_name))
> +		return;

All the returns in this function are leaking env...

> +	if (add_uevent_var(env, "IOC_ID=%u", mrioc->id))
> +		return;
> +	if (add_uevent_var(env, "FAULT_CODE=0x%08x", mrioc->saved_fault_code))
> +		return;
> +	if (add_uevent_var(env, "FAULT_INFO0=0x%08x",
> +	     mrioc->saved_fault_info[0]))
> +		return;
> +	if (add_uevent_var(env, "FAULT_INFO1=0x%08x",
> +	     mrioc->saved_fault_info[1]))
> +		return;
> +	if (add_uevent_var(env, "FAULT_INFO2=0x%08x",
> +	    mrioc->saved_fault_info[2]))
> +		return;
> +
> +	kobject_uevent_env(&mrioc->shost->shost_gendev.kobj,
> +	    KOBJ_CHANGE, env->envp);

Please align the arguments after the "(".

> +	kfree(env);
> +}


-- 
Damien Le Moal
Western Digital Research