From: Yihang Li <liyihang9@huawei.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Arnd Bergmann <arnd@arndb.de>,
Damien Le Moal <dlemoal@kernel.org>,
John Garry <john.g.garry@oracle.com>,
Bart Van Assche <bvanassche@acm.org>,
Jason Yan <yanaijie@huawei.com>,
Igor Pylypiv <ipylypiv@google.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <liyihang9@huawei.com>
Subject: Re: [PATCH] scsi: hisi: remove incorrect ACPI_PTR annotations
Date: Wed, 5 Mar 2025 09:36:25 +0800 [thread overview]
Message-ID: <c75288a5-9e3c-e4c7-4717-9c04348dc7d4@huawei.com> (raw)
In-Reply-To: <h7oh3uhuvmulmqkxi5x73bnkmgkodjxemabiqwkrqu3jmbxu2e@p2pmhpxh6nxl>
On 2025/3/4 13:12, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Feb 26, 2025 at 11:23:18AM +0800, Yihang Li wrote:
>> On 2025/2/26 0:36, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> Building with W=1 shows a warning about sas_v2_acpi_match being unused when
>>> CONFIG_OF is disabled:
>>>
>>> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas_v2_acpi_match' [-Werror,-Wunused-const-variable]
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Looks good. So Reviewed-by: Yihang Li <liyihang9@huawei.com>
>
> If you put your Reviewed-by tag in a separate line, the tooling that
> most maintainers use pick it up automatically. Martin applied your patch
> (currently as commit 7a9c0476d4073e742f474e71feeef4f54add4bc9 in
> https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git 6.15/scsi-staging
> ) indeed without your tag.
>
Ok, thanks for the reminder. I'll pay attention next time.
Thanks
Yihang
next prev parent reply other threads:[~2025-03-05 1:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 16:36 [PATCH] scsi: hisi: remove incorrect ACPI_PTR annotations Arnd Bergmann
2025-02-26 2:13 ` Damien Le Moal
2025-02-26 3:23 ` Yihang Li
2025-03-04 5:12 ` Uwe Kleine-König
2025-03-05 1:36 ` Yihang Li [this message]
2025-03-04 2:04 ` Martin K. Petersen
2025-03-11 1:19 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c75288a5-9e3c-e4c7-4717-9c04348dc7d4@huawei.com \
--to=liyihang9@huawei.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=ipylypiv@google.com \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox