From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "dan.carpenter@linaro.org" <dan.carpenter@linaro.org>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"quic_ziqichen@quicinc.com" <quic_ziqichen@quicinc.com>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
"Stanley Chu (朱原陞)" <stanley.chu@mediatek.com>,
"athierry@redhat.com" <athierry@redhat.com>,
"quic_cang@quicinc.com" <quic_cang@quicinc.com>
Subject: Re: [PATCH] scsi: ufs: uninitialized variable in ufshcd_devfreq_target()
Date: Thu, 15 Feb 2024 05:53:40 +0000 [thread overview]
Message-ID: <c83762bcdafd9547f73ffd998adcd2bb338bbe05.camel@mediatek.com> (raw)
In-Reply-To: <c787d37f-1107-4512-8991-bccf80e74a35@moroto.mountain>
On Tue, 2024-02-13 at 21:08 +0300, Dan Carpenter wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> There is one goto where "sched_clk_scaling_suspend_work" is true but
> "scale_up" is uninitialized. It leads to a Smatch uninitialized
> variable
> warning:
>
> drivers/ufs/core/ufshcd.c:1589 ufshcd_devfreq_target() error:
> uninitialized symbol 'scale_up'.
>
> Fixes: 1d969731b87f ("scsi: ufs: core: Only suspend clock scaling if
> scaling down")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
next prev parent reply other threads:[~2024-02-15 5:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 18:08 [PATCH] scsi: ufs: uninitialized variable in ufshcd_devfreq_target() Dan Carpenter
2024-02-15 5:53 ` Peter Wang (王信友) [this message]
2024-02-15 18:22 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c83762bcdafd9547f73ffd998adcd2bb338bbe05.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=athierry@redhat.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=dan.carpenter@linaro.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_ziqichen@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox