From: Damien Le Moal <dlemoal@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Mike Christie <michael.christie@oracle.com>,
John Garry <john.g.garry@oracle.com>,
Ming Lei <ming.lei@redhat.com>,
Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Don Brace <don.brace@microchip.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH] scsi: core: Improve type safety of scsi_rescan_device()
Date: Tue, 22 Aug 2023 14:47:38 +0900 [thread overview]
Message-ID: <c8476456-ae88-f7a9-5ef2-a6db406876ca@kernel.org> (raw)
In-Reply-To: <20230821204009.3601639-1-bvanassche@acm.org>
On 8/22/23 05:40, Bart Van Assche wrote:
> Most callers of scsi_rescan_device() have the scsi_device pointer
s/Most/All ? If it is most, then you have an issue somewhere :)
> available. Pass a struct scsi_device pointer to scsi_rescan_device()
> instead of a struct device pointer. This change prevents that a
> pointer to another struct device pointer would be passed accidentally to
...pointer to another struct device to be passed accidentally to...
> scsi_rescan_device().
>
> Remove the scsi_rescan_device() declaration from the scsi_priv.h header
> file since it duplicates the declaration in <scsi/scsi_host.h>.
With the above nits fixed, feel free to add:
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-08-22 5:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 20:40 [PATCH] scsi: core: Improve type safety of scsi_rescan_device() Bart Van Assche
2023-08-22 5:47 ` Damien Le Moal [this message]
2023-08-22 6:51 ` Hannes Reinecke
2023-08-22 8:09 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8476456-ae88-f7a9-5ef2-a6db406876ca@kernel.org \
--to=dlemoal@kernel.org \
--cc=aacraid@microsemi.com \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=decui@microsoft.com \
--cc=don.brace@microchip.com \
--cc=haiyangz@microsoft.com \
--cc=hare@suse.de \
--cc=jasowang@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=john.g.garry@oracle.com \
--cc=kys@microsoft.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=ming.lei@redhat.com \
--cc=mst@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox