Re: [PATCH 15/42] NCR5380: use SCSI result accessors

Hannes Reinecke
2021-04-26T08:30:24Z

On 4/22/21 6:10 PM, Bart Van Assche wrote:
> On 4/21/21 11:37 PM, Hannes Reinecke wrote:
>> On 4/21/21 11:11 PM, Bart Van Assche wrote:
>>> Do all SCSI devices from the nineties report SCSI status values with
>>> the lower bit set to 0? If so, can the status_byte() macro be removed
>>> entirely?
>>>
>> As indicated in the previous reply, yes, that is the plan (removing the
>> status_byte() macro). And the drivers will have to report SCSI status
>> values with the lower bit cleared, otherwise the linux SCSI status codes
>> would never have worked in the first place.
>
> Please elaborate the above further. My understanding is that SCSI-2
> defines bits 0, 6 and 7 of the status byte as reserved while SAM-2
> specifies that these bits must be zero for the status codes that also
> have been defined in SCSI-2. Is it safe to assume that all SCSI-2
> devices set the reserved bits to zero?
>
Yes. At least we haven't encountered any devices which do.
And are quite unlikely to find any new or unknown SCSI-2 devices, as the
market for SCSI parallel drives is _quite_ small :-)

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, 90409 Nürnberg
GF: F. Imendörffer, HRB 36809 (AG Nürnberg)