From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6323E1F03D8; Tue, 7 Jan 2025 11:35:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736249733; cv=none; b=NUHlZy5/ELSrrybk1MJUVyixfNdKu0I7ry58hkPKcM96kpvGdbonEFiL/jG7/aJpnwLBl3rExYjArPdZ0hoXN0Z/PUavBQLnjD0i7Ca+eKWF3DrwPcA8drZoC7KXMr8hn53INu8BXkSLgH4gf8dHpe/GgsurZSuGXdW4h+sausE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736249733; c=relaxed/simple; bh=F9rP2leHEwoPH7snKeuOxzdGmST5zgThzTUc7hfxUa0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eoD1Q7Y8y2/GRAfX01oJke3/g1yyI9vY8mSIo5H+EuVxiIuFBfTZnic9OmkHbSCpfZ2BiJ2vAN3RmmnFFDzQ4O5y/5KYYJK+/CddQZU1NiUhKKpaVaoPHcC2B6kM+piMlF9U63HMw5yq8lg9qDq4fXtXWambVypoGzns4A0z/tQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=AAHXwTqp; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=mqshM3gD; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=AAHXwTqp; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=mqshM3gD; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="AAHXwTqp"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="mqshM3gD"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="AAHXwTqp"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="mqshM3gD" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2E4AA2111F; Tue, 7 Jan 2025 11:35:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1736249727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7EKA//0hSGrefRQSomMjyzuIn2WGE3ajOvbDc0AzWPM=; b=AAHXwTqpYVLlZe5d5YIkrcrCb3SwJMOcHiY8ExWLkeMpdttuIoxuQIGgOnglK2gP4rxEXO wQp9E6zeaiI95xKT7UAT4BxFjulwuokjcsgOUuA+DrcHm1MgBC8SWYTizFSiLGy6zwytg4 t/jn4vdfBaqSdPaplAQGPQj910zwgYQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1736249727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7EKA//0hSGrefRQSomMjyzuIn2WGE3ajOvbDc0AzWPM=; b=mqshM3gD2TtT6A0Zz9YHTg0RZrB7LtoMKbp8XCRJ4HpINzuqurX95wI5nTLMOnB9JmVhUS nLa/MxZg+swUp5Dg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1736249727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7EKA//0hSGrefRQSomMjyzuIn2WGE3ajOvbDc0AzWPM=; b=AAHXwTqpYVLlZe5d5YIkrcrCb3SwJMOcHiY8ExWLkeMpdttuIoxuQIGgOnglK2gP4rxEXO wQp9E6zeaiI95xKT7UAT4BxFjulwuokjcsgOUuA+DrcHm1MgBC8SWYTizFSiLGy6zwytg4 t/jn4vdfBaqSdPaplAQGPQj910zwgYQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1736249727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7EKA//0hSGrefRQSomMjyzuIn2WGE3ajOvbDc0AzWPM=; b=mqshM3gD2TtT6A0Zz9YHTg0RZrB7LtoMKbp8XCRJ4HpINzuqurX95wI5nTLMOnB9JmVhUS nLa/MxZg+swUp5Dg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3414C13A6A; Tue, 7 Jan 2025 11:35:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id NYcmCHwRfWcAfQAAD6G6ig (envelope-from ); Tue, 07 Jan 2025 11:35:24 +0000 Message-ID: Date: Tue, 7 Jan 2025 12:35:23 +0100 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/9] lib/group_cpus: let group_cpu_evenly return number of groups To: Daniel Wagner Cc: Daniel Wagner , Jens Axboe , Keith Busch , Christoph Hellwig , Sagi Grimberg , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , "Martin K. Petersen" , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, Don Brace , "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Xuan Zhuo , Andrew Morton , Thomas Gleixner , Costa Shulyupin , Juri Lelli , Valentin Schneider , Waiman Long , Ming Lei , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Frederic Weisbecker , Mel Gorman , Sridhar Balaraman , "brookxu.cn" , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, storagedev@microchip.com, virtualization@lists.linux.dev References: <20241217-isolcpus-io-queues-v4-0-5d355fbb1e14@kernel.org> <20241217-isolcpus-io-queues-v4-1-5d355fbb1e14@kernel.org> <1a2fe8aa-d3e1-4e36-8cd5-27141c1d7178@suse.de> <1d7b96ca-a015-4730-9035-abb69cd6cda4@flourine.local> <5eaeec6d-48fd-4fb7-90ac-70f596572644@suse.de> <63489abb-0cdd-4963-8618-a6ce17432732@flourine.local> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <63489abb-0cdd-4963-8618-a6ce17432732@flourine.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Level: X-Spamd-Result: default: False [-6.80 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[39]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[kernel.org,kernel.dk,lst.de,grimberg.me,broadcom.com,oracle.com,marvell.com,microchip.com,redhat.com,linux.alibaba.com,linux-foundation.org,linutronix.de,suse.com,suse.de,parallelwireless.com,gmail.com,vger.kernel.org,lists.infradead.org,lists.linux.dev]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLwoqrtcdrtewo8fubna94zinu)]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo] X-Spam-Score: -6.80 X-Spam-Flag: NO On 1/7/25 11:46, Daniel Wagner wrote: > On Tue, Jan 07, 2025 at 11:35:10AM +0100, Hannes Reinecke wrote: >> On 1/7/25 09:20, Daniel Wagner wrote: >>> On Tue, Jan 07, 2025 at 08:51:57AM +0100, Hannes Reinecke wrote: >>>>> void blk_mq_map_queues(struct blk_mq_queue_map *qmap) >>>>> { >>>>> const struct cpumask *masks; >>>>> - unsigned int queue, cpu; >>>>> + unsigned int queue, cpu, nr_masks; >>>>> - masks = group_cpus_evenly(qmap->nr_queues); >>>>> + nr_masks = qmap->nr_queues; >>>>> + masks = group_cpus_evenly(&nr_masks); >>>> >>>> Hmph. I am a big fan of separating input and output paramenters; >>>> most ABI definitions will be doing that anyway. >>>> Makes it also really hard to track whether the output parameters >>>> had been set at all. Care to split it up? >>> >>> What API do you have in mind? >> >> ABI, not API. > > I got that, still what C API do you want to see? > masks = group_cpus_evenly(qmap->nr_queues, &nr_queues); maybe? Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich