From: Bart Van Assche <bvanassche@acm.org>
To: Kiwoong Kim <kwmad.kim@samsung.com>,
linux-scsi@vger.kernel.org, sc.suh@samsung.com,
hy50.seo@samsung.com, sh425.lee@samsung.com,
kwangwon.min@samsung.com, junwoo80.lee@samsung.com
Subject: Re: [PATCH v2 3/3] ufs: poll pmc until another pa request is completed
Date: Thu, 8 Jun 2023 09:28:48 -0700 [thread overview]
Message-ID: <cc269205-71cc-19a8-c83c-a908c2f2a587@acm.org> (raw)
In-Reply-To: <005801d999b4$38cb2260$aa616720$@samsung.com>
On 6/7/23 19:52, Kiwoong Kim wrote:
> I got it and I have one question.
>
> The reason why I bound all the three things is
> because I thought they were tangled each other. I felt that the first patch relies
> on both the second one and the third one and the helper named __ufshcd_poll_uic_pwr
> in the third one calls ufshcd_ready_for_uic_cmd where the change of the second one is applied.
> So I thought I should care this sort of conflict in terms of the driver's working.
> Don't submitters need to care this?
Sorry but the above is not clear to me so I don't know what to answer.
As you may have noticed, the request for one change per patch is a
common request. From Documentation/process/submitting-patches.rst:
"Solve only one problem per patch. If your description starts to get
long, that's a sign that you probably need to split up your patch.
See :ref:`split_changes`."
Thanks,
Bart.
prev parent reply other threads:[~2023-06-08 16:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230605012505epcas2p4fa6facb5ad68289d0e7904bc77ea8506@epcas2p4.samsung.com>
2023-06-05 1:15 ` [PATCH v2 0/3] change UIC command handling Kiwoong Kim
[not found] ` <CGME20230605012506epcas2p2c487b751827e3a39c74fdbd88dbd1311@epcas2p2.samsung.com>
2023-06-05 1:15 ` [PATCH v2 1/3] ufs: make __ufshcd_send_uic_cmd not wrapped by host_lock Kiwoong Kim
2023-06-07 18:54 ` Bart Van Assche
[not found] ` <CGME20230605012507epcas2p3ecc0a358b558fe09d74a56b67b6477d2@epcas2p3.samsung.com>
2023-06-05 1:15 ` [PATCH v2 2/3] ufs: poll HCS.UCRDY before issuing a UIC command Kiwoong Kim
2023-06-05 7:05 ` Avri Altman
2023-06-08 2:38 ` Kiwoong Kim
[not found] ` <CGME20230605012508epcas2p140e42906361b870e20b1e734e9e4df06@epcas2p1.samsung.com>
2023-06-05 1:15 ` [PATCH v2 3/3] ufs: poll pmc until another pa request is completed Kiwoong Kim
2023-06-07 19:01 ` Bart Van Assche
2023-06-08 2:52 ` Kiwoong Kim
2023-06-08 16:28 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc269205-71cc-19a8-c83c-a908c2f2a587@acm.org \
--to=bvanassche@acm.org \
--cc=hy50.seo@samsung.com \
--cc=junwoo80.lee@samsung.com \
--cc=kwangwon.min@samsung.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sc.suh@samsung.com \
--cc=sh425.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).